[PR #12] [MERGED] fix(technique-combine-people): name current node classes, not deprecated ones #13

New issue

Closed

opened 2026-10-26 22:33:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:33:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/12
Author: @mattmillerai
Created: 7/31/2026
Status: ✅ Merged
Merged: 8/5/2026
Merged by: @mattmillerai

Base: main ← Head: matt/be-5442-technique-deprecated-classes

📝 Commits (1)

cf19fd6 fix(technique-combine-people): name current node classes, not deprecated ones

📊 Changes

1 file changed (+15 additions, -15 deletions)

View changed files

📝 skills/technique-combine-people.md (+15 -15)

📄 Description

The technique-combine-people recipe instructs agents to build with ImageBatch and to generate with GeminiNanoBanana2. Both are deprecated: true in the Comfy Cloud node catalog — ImageBatch's display name is literally Batch Images (DEPRECATED) — and the Comfy Cloud MCP server's search_nodes hides deprecated nodes by default (BE-3314).

So an agent that follows the recipe and then searches for the classes it just used gets nothing back. The workflows still run (deprecated nodes execute), so this is guidance quality rather than breakage — but it is exactly the inconsistency the deprecation filter exists to avoid, and this recipe is about to be served through the MCP server as get_creative_technique / comfy://guides/techniques/combine-people (comfy-cloud-mcp-server#991, BE-5442). Caught in review there.

What changed

Verified against the bundled object_info catalog (data/object_info.json.gz in comfy-cloud-mcp-server), not guessed:

Old	Status	Current
`ImageBatch`	`deprecated: true`, display name `Batch Images (DEPRECATED)`	`BatchImagesNode` (`deprecated: false`, display name `Batch Images`)
`GeminiNanoBanana2`	`deprecated: true`	`GeminiNanoBanana2V2` (`deprecated: false`, same display name `Nano Banana 2`)

Step 2/4 → GeminiNanoBanana2V2. Its model input is a COMFY_DYNAMICCOMBO_V3, so the settings it gates are addressed by their dotted names (model.thinking_level, model.resolution, model.aspect_ratio, model.images.*) rather than flat, as they were on the old class. seed and response_modalities are top level on the new class and stay top level in the recipe — the settings list now says which is which, because sending a gated sub-field flat fails with required_input_missing.
Step 3 no longer needs a batching node. GeminiNanoBanana2V2 takes up to 14 references directly, as auto-grow slots model.images.image_1 … model.images.image_14, so the two references wire straight in. This is what removes the ImageBatch recommendation rather than merely swapping it.
BatchImagesNode is kept only as an aside for graphs that do want a standalone batch. The recipe points at get_node({ names: ["BatchImagesNode"] }) for the slot names instead of stating them: its images input is an auto-grow list with no enumerated slot names in the catalog, so the old literal {"image1": ..., "image2": ...} JSON snippet would have been a guess. Dropped rather than re-guessed.

Both old class names are still mentioned, each on a line that says it is deprecated. That is deliberate: an agent holding the old name should be redirected, not dead-ended.

Nothing else in the recipe changed — the prompt-structure guidance, example prompt, model-comparison table, and key learnings are untouched.

Why it matters here rather than downstream

Comfy-Org/comfy-skills is the single source of truth; comfy-cloud-mcp-server mirrors skills/*.md into data/skills.json daily via refresh-skills.yml. A fix made only in that snapshot is reverted by the next refresh, so the edit lands here. comfy-cloud-mcp-server#991 carries the matching snapshot patch (so the surface ships correct on day one) plus a lint that fails CI if a refresh ever reintroduces a deprecated class into a served recipe.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/12 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 7/31/2026 **Status:** ✅ Merged **Merged:** 8/5/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/be-5442-technique-deprecated-classes` --- ### 📝 Commits (1) - [`cf19fd6`](https://github.com/Comfy-Org/comfy-skills/commit/cf19fd69f23abb7458476018aaa246739ce0ed74) fix(technique-combine-people): name current node classes, not deprecated ones ### 📊 Changes **1 file changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `skills/technique-combine-people.md` (+15 -15) </details> ### 📄 Description The `technique-combine-people` recipe instructs agents to build with `ImageBatch` and to generate with `GeminiNanoBanana2`. Both are `deprecated: true` in the Comfy Cloud node catalog — `ImageBatch`'s display name is literally `Batch Images (DEPRECATED)` — and the Comfy Cloud MCP server's `search_nodes` hides deprecated nodes by default (BE-3314). So an agent that follows the recipe and then searches for the classes it just used gets nothing back. The workflows still *run* (deprecated nodes execute), so this is guidance quality rather than breakage — but it is exactly the inconsistency the deprecation filter exists to avoid, and this recipe is about to be served through the MCP server as `get_creative_technique` / `comfy://guides/techniques/combine-people` ([comfy-cloud-mcp-server#991](https://github.com/Comfy-Org/comfy-cloud-mcp-server/pull/991), BE-5442). Caught in review there. ## What changed Verified against the bundled `object_info` catalog (`data/object_info.json.gz` in comfy-cloud-mcp-server), not guessed: | Old | Status | Current | | :-- | :-- | :-- | | `ImageBatch` | `deprecated: true`, display name `Batch Images (DEPRECATED)` | `BatchImagesNode` (`deprecated: false`, display name `Batch Images`) | | `GeminiNanoBanana2` | `deprecated: true` | `GeminiNanoBanana2V2` (`deprecated: false`, same display name `Nano Banana 2`) | - **Step 2/4 → `GeminiNanoBanana2V2`.** Its `model` input is a `COMFY_DYNAMICCOMBO_V3`, so the settings it gates are addressed by their dotted names (`model.thinking_level`, `model.resolution`, `model.aspect_ratio`, `model.images.*`) rather than flat, as they were on the old class. `seed` and `response_modalities` are top level on the new class and stay top level in the recipe — the settings list now says which is which, because sending a gated sub-field flat fails with `required_input_missing`. - **Step 3 no longer needs a batching node.** `GeminiNanoBanana2V2` takes up to 14 references directly, as auto-grow slots `model.images.image_1` … `model.images.image_14`, so the two references wire straight in. This is what removes the `ImageBatch` recommendation rather than merely swapping it. - **`BatchImagesNode` is kept only as an aside** for graphs that do want a standalone batch. The recipe points at `get_node({ names: ["BatchImagesNode"] })` for the slot names instead of stating them: its `images` input is an auto-grow list with no enumerated slot names in the catalog, so the old literal `{"image1": ..., "image2": ...}` JSON snippet would have been a guess. Dropped rather than re-guessed. Both old class names are still mentioned, each on a line that says it is deprecated. That is deliberate: an agent holding the old name should be redirected, not dead-ended. Nothing else in the recipe changed — the prompt-structure guidance, example prompt, model-comparison table, and key learnings are untouched. ## Why it matters here rather than downstream `Comfy-Org/comfy-skills` is the single source of truth; comfy-cloud-mcp-server mirrors `skills/*.md` into `data/skills.json` daily via `refresh-skills.yml`. A fix made only in that snapshot is reverted by the next refresh, so the edit lands here. comfy-cloud-mcp-server#991 carries the matching snapshot patch (so the surface ships correct on day one) plus a lint that fails CI if a refresh ever reintroduces a deprecated class into a served recipe. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:33:58 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#13

No description provided.

Rows
Columns