Comfy-Org/comfy-skills

Fork 0

mirror of https://github.com/Comfy-Org/comfy-skills.git synced 2026-11-04 23:37:45 +00:00

[PR #15] [MERGED] fix(generate-video): dual-route MiniMax H3, add model notes #14

New issue

Closed

opened 2026-10-26 22:33:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:33:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/15
Author: @skishore23
Created: 8/7/2026
Status: ✅ Merged
Merged: 8/7/2026
Merged by: @skishore23

Base: main ← Head: h3-knowledge-and-dual-route

📝 Commits (3)

a16ae6d fix(generate-video): dual-route MiniMax H3, add model notes
4f295bf fix(generate-video): extend dual-route fix to the canonical command
c6bcedc fix(generate-video): address CodeRabbit review on PR #15

📊 Changes

3 files changed (+67 additions, -3 deletions)

View changed files

📝 claude-code/commands/generate-video.md (+29 -1)
📝 openclaw/comfy/SKILL.md (+9 -1)
📝 skills/comfy-generate-video.md (+29 -1)

📄 Description

Summary

Fixes the video command's Step 0 in both copies — claude-code/commands/generate-video.md (the canonical plugin command, per README) and skills/comfy-generate-video.md (the legacy mirror for the deprecated curl installer). Step 0 previously routed any named model family (e.g. "MiniMax") straight to partner_generate and stopped, with no path back to an OSS/free route. MiniMax H3 ships BOTH ways — free OSS weights and a paid partner node, under the identical display title "MiniMax H3: Text to Video" — so agents following the old Step 0 literally were telling users the free route didn't exist.
Step 0 in both files now checks search_templates (OSS) alongside search_nodes (partner) for the named family. Families that exist only as a partner node still route straight there. Families with both routes get stated to the user (free OSS vs. paid partner, with tradeoffs) and the agent asks instead of assuming paid — unless the user already specified or one route is infeasible.
Adds a "Model notes: MiniMax H3" section to both files with current specifics: the OSS-vs-API naming split (video_minimax_h3_* vs api_minimax_h3_*), hardware-based time expectations (dynamic VRAM, benchmark numbers, non-linear scaling), recommended model files, the model's real limits vs. the API node's dropdown presets, and the disconnected-helper-node gotcha in the OSS i2v template.
Adds a lighter consistency note to openclaw/comfy/SKILL.md's "Which tools to use" section — it has its own unstructured version of the same "named model → call partner_generate" guidance with no OSS-route consideration.

Distinct pre-existing bug fixed in the same edit: claude-code/commands/generate-video.md still checked node category api node/, which matches zero live nodes — the catalog files partner nodes under partner/. This was already fixed in the three sibling skills/*.md files by commit cf7949d but never carried into claude-code/commands/. Leaving it in place would have made the Step 0 rewrite in this PR wrong (the partner-only branch would never fire), so it's fixed here as part of touching that exact line, not scope creep.

Why

QA ("Solid Minimax H3 experience") caught agents claiming MiniMax H3 has no free version and routing users straight to paid partner nodes. That's Step 0 encoding paid-first routing for every named model family, with no OSS fallback consideration — a bug in skill form, not a one-off mistake. The canonical command (claude-code/commands/) is the one users actually install via the plugin, so it's the headline fix; skills/ is kept in sync as the legacy mirror.

Model facts rot, so the new sections are date-stamped "as of 2026-08" and tell the agent to re-verify current details with the live tools rather than trusting the numbers indefinitely.

Other copies found (and disposition)

Searched the whole repo for the video command's content and for the auto-partner-routing pattern:

claude-code/commands/generate-video.md — canonical copy, fixed (Step 0 + Model notes + api node/ → partner/ drift).
skills/comfy-generate-video.md — legacy mirror, fixed (same Step 0 + Model notes, done in the prior commit on this branch).
openclaw/comfy/SKILL.md — a single unified skill doc covering image/video/audio/3D for the OpenClaw client. Not a duplicate of the video command (different structure, no numbered Step 0), but its "Which tools to use" section carries the same underlying defect for named models. Fixed with a scoped caveat rather than the full Model notes block, since the doc isn't video-specific.
claude-code/commands/generate-image.md, generate-audio.md, and their skills/ counterparts — have their own Step-0-shaped partner routing, but grepping for MiniMax/minimax/Hailuo across the whole repo turns up nothing outside the video files, so no other family-specific fix was needed there.
.claude-plugin/marketplace.json, README.md — reference the video command by name/table entry only, no routing logic to fix.

Test plan

claude plugin validate ./claude-code — passes.
Diffed both video command copies for wording consistency (same substance, adjusted only for each file's existing structure/frontmatter).
Grepped the full repo for MiniMax/minimax/Hailuo and for other copies of the video command's content — none missed.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/15 **Author:** [@skishore23](https://github.com/skishore23) **Created:** 8/7/2026 **Status:** ✅ Merged **Merged:** 8/7/2026 **Merged by:** [@skishore23](https://github.com/skishore23) **Base:** `main` ← **Head:** `h3-knowledge-and-dual-route` --- ### 📝 Commits (3) - [`a16ae6d`](https://github.com/Comfy-Org/comfy-skills/commit/a16ae6d8b391159c03b786d061ad4b72e8901ef4) fix(generate-video): dual-route MiniMax H3, add model notes - [`4f295bf`](https://github.com/Comfy-Org/comfy-skills/commit/4f295bfd8ca5a3cf932c432d3a5841378a2f88e3) fix(generate-video): extend dual-route fix to the canonical command - [`c6bcedc`](https://github.com/Comfy-Org/comfy-skills/commit/c6bcedcdb5aba8b1841beadfcf0a449ddf94abe8) fix(generate-video): address CodeRabbit review on PR #15 ### 📊 Changes **3 files changed** (+67 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `claude-code/commands/generate-video.md` (+29 -1) 📝 `openclaw/comfy/SKILL.md` (+9 -1) 📝 `skills/comfy-generate-video.md` (+29 -1) </details> ### 📄 Description ## Summary - Fixes the video command's Step 0 in **both copies** — `claude-code/commands/generate-video.md` (the canonical plugin command, per README) and `skills/comfy-generate-video.md` (the legacy mirror for the deprecated curl installer). Step 0 previously routed any named model family (e.g. "MiniMax") straight to `partner_generate` and stopped, with no path back to an OSS/free route. MiniMax H3 ships BOTH ways — free OSS weights and a paid partner node, under the identical display title "MiniMax H3: Text to Video" — so agents following the old Step 0 literally were telling users the free route didn't exist. - Step 0 in both files now checks `search_templates` (OSS) alongside `search_nodes` (partner) for the named family. Families that exist only as a partner node still route straight there. Families with both routes get stated to the user (free OSS vs. paid partner, with tradeoffs) and the agent asks instead of assuming paid — unless the user already specified or one route is infeasible. - Adds a "Model notes: MiniMax H3" section to both files with current specifics: the OSS-vs-API naming split (`video_minimax_h3_*` vs `api_minimax_h3_*`), hardware-based time expectations (dynamic VRAM, benchmark numbers, non-linear scaling), recommended model files, the model's real limits vs. the API node's dropdown presets, and the disconnected-helper-node gotcha in the OSS i2v template. - Adds a lighter consistency note to `openclaw/comfy/SKILL.md`'s "Which tools to use" section — it has its own unstructured version of the same "named model → call `partner_generate`" guidance with no OSS-route consideration. **Distinct pre-existing bug fixed in the same edit**: `claude-code/commands/generate-video.md` still checked node category `api node/`, which matches zero live nodes — the catalog files partner nodes under `partner/`. This was already fixed in the three sibling `skills/*.md` files by commit `cf7949d` but never carried into `claude-code/commands/`. Leaving it in place would have made the Step 0 rewrite in this PR wrong (the partner-only branch would never fire), so it's fixed here as part of touching that exact line, not scope creep. ## Why QA ("Solid Minimax H3 experience") caught agents claiming MiniMax H3 has no free version and routing users straight to paid partner nodes. That's Step 0 encoding paid-first routing for every named model family, with no OSS fallback consideration — a bug in skill form, not a one-off mistake. The canonical command (`claude-code/commands/`) is the one users actually install via the plugin, so it's the headline fix; `skills/` is kept in sync as the legacy mirror. Model facts rot, so the new sections are date-stamped "as of 2026-08" and tell the agent to re-verify current details with the live tools rather than trusting the numbers indefinitely. ## Other copies found (and disposition) Searched the whole repo for the video command's content and for the auto-partner-routing pattern: - `claude-code/commands/generate-video.md` — canonical copy, **fixed** (Step 0 + Model notes + `api node/` → `partner/` drift). - `skills/comfy-generate-video.md` — legacy mirror, **fixed** (same Step 0 + Model notes, done in the prior commit on this branch). - `openclaw/comfy/SKILL.md` — a single unified skill doc covering image/video/audio/3D for the OpenClaw client. Not a duplicate of the video command (different structure, no numbered Step 0), but its "Which tools to use" section carries the same underlying defect for named models. **Fixed** with a scoped caveat rather than the full Model notes block, since the doc isn't video-specific. - `claude-code/commands/generate-image.md`, `generate-audio.md`, and their `skills/` counterparts — have their own Step-0-shaped partner routing, but grepping for `MiniMax`/`minimax`/`Hailuo` across the whole repo turns up nothing outside the video files, so no other family-specific fix was needed there. - `.claude-plugin/marketplace.json`, `README.md` — reference the video command by name/table entry only, no routing logic to fix. ## Test plan - [x] `claude plugin validate ./claude-code` — passes. - [x] Diffed both video command copies for wording consistency (same substance, adjusted only for each file's existing structure/frontmatter). - [x] Grepped the full repo for `MiniMax`/`minimax`/`Hailuo` and for other copies of the video command's content — none missed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:33:58 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#14

No description provided.

Rows
Columns