Comfy-Org/comfy-skills

Fork 0

mirror of https://github.com/Comfy-Org/comfy-skills.git synced 2026-11-04 23:37:45 +00:00

[PR #21] [MERGED] feat(comfy-build): scaffold the builder skill under comfy-cli/ #20

New issue

Closed

opened 2026-10-26 22:34:02 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/21
Author: @james00012
Created: 8/20/2026
Status: ✅ Merged
Merged: 8/21/2026
Merged by: @james00012

Base: main ← Head: feat/comfy-build-skill-scaffold

📝 Commits (2)

e76914c feat(comfy-build): scaffold the builder skill under comfy-cli/
c924d6b ci: pin the validate workflow's actions and drop credential persistence

📊 Changes

3 files changed (+93 additions, -0 deletions)

View changed files

➕ .github/workflows/validate-skills.yml (+45 -0)
📝 README.md (+1 -0)
➕ comfy-cli/comfy-build/SKILL.md (+47 -0)

📄 Description

Why

comfy skills install is about to fetch a sixth skill from this repo, so that revising the builder skill's judgment never waits on a comfy-cli release. This PR is the container that fetch resolves to: valid to the installer's contract, and empty of the judgment the build features fill in.

Change: [comfy-skills] The builder skill's scaffold and home · Feature: the builder skill reaches the user's agent · Design: Local agent access to the builder via comfy-cli skills

What lands

comfy-cli/comfy-build/SKILL.md: one directory, one file, name: frontmatter equal to the directory name. A signpost body saying what will fill it and telling an agent not to improvise a build in the meantime, since cutting a version costs the user money.
A new top-level comfy-cli/ folder: skills that comfy-cli's installer fetches, as a sibling of openclaw/, which already groups a directory-shaped skill by the host that consumes it.
.github/workflows/validate-skills.yml: runs the CLI's own comfy skills validate over every directory under comfy-cli/. The contract lives in the CLI, not restated here.
README repo layout: one bullet for comfy-cli/, since the layout list is the only place that says where a file belongs.

Where this sits

flowchart LR
    REPO["comfy-skills · the builder skill's home ◀ this PR"]
    INST["comfy-cli · the skills installer"]
    DIRS["agent skill directories<br>Claude Code, Cursor, AGENTS.md"]
    FIVE["the five bundled skills"]
    REPO --> INST
    FIVE --> INST
    INST --> DIRS
    classDef out fill:#f5f5f5,stroke:#bbbbbb,stroke-dasharray:4 3,color:#888888;
    classDef feat fill:#ffe08a,stroke:#b8860b,color:#000;
    classDef task fill:#ffe08a,stroke:#1a7f37,stroke-width:4px,color:#000;
    class FIVE,INST,DIRS out
    class REPO task

Validation

Local stack, end to end: comfy-cli 1.16-equivalent from source (comfy_cli at 0a6cb6e), against this working tree:

comfy skills validate comfy-cli/comfy-build → {"valid": true, "name": "comfy-build", "bundled": false}.
comfy skills install --scope project --skill <abs path>/comfy-cli/comfy-build → wrote for all three targets: .claude/skills/comfy-build/SKILL.md, .cursor/rules/comfy-build.mdc, and a  fence in AGENTS.md.

Not run: the new CI workflow itself, which first executes on this PR, and anything involving a remote fetch, which is the comfy-cli change's job.

Departures from the plan

Three, all declared

Path moved from skills/ to comfy-cli/. The plan said skills/comfy-build/SKILL.md and called it "first of its kind in the repo". Both are wrong against the repo as it stands: this README documents skills/ as legacy and frozen pending removal with the comfy-cloud-mcp curl installer, and openclaw/comfy/SKILL.md is already a directory-shaped skill carrying name:/description: frontmatter that passes the CLI's contract today.
No named release. The plan's deliverable included a tag for the fetch to pin. James chose to pin to main instead, so no tag is cut here and the CLI resolves main on every install.
CI validate added. The plan left this to the task's judgement. Added, because the rule most likely to be got wrong, directory name equals frontmatter name:, otherwise fails on a user's machine at install time rather than on the PR that broke it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/21 **Author:** [@james00012](https://github.com/james00012) **Created:** 8/20/2026 **Status:** ✅ Merged **Merged:** 8/21/2026 **Merged by:** [@james00012](https://github.com/james00012) **Base:** `main` ← **Head:** `feat/comfy-build-skill-scaffold` --- ### 📝 Commits (2) - [`e76914c`](https://github.com/Comfy-Org/comfy-skills/commit/e76914c029867dd558c0cb17e7b0dbf5dcdb03ce) feat(comfy-build): scaffold the builder skill under comfy-cli/ - [`c924d6b`](https://github.com/Comfy-Org/comfy-skills/commit/c924d6b7b533f0f28b38d815aafe0e5a86164373) ci: pin the validate workflow's actions and drop credential persistence ### 📊 Changes **3 files changed** (+93 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/validate-skills.yml` (+45 -0) 📝 `README.md` (+1 -0) ➕ `comfy-cli/comfy-build/SKILL.md` (+47 -0) </details> ### 📄 Description ## Why `comfy skills install` is about to fetch a sixth skill from this repo, so that revising the builder skill's judgment never waits on a comfy-cli release. This PR is the container that fetch resolves to: valid to the installer's contract, and empty of the judgment the build features fill in. Change: [\[comfy-skills\] The builder skill's scaffold and home](https://app.notion.com/p/3c26d73d3650819bb2d3c0e7da5ec925) · Feature: [the builder skill reaches the user's agent](https://app.notion.com/p/3c26d73d3650817cbd18f0e48f21ea8c) · Design: [Local agent access to the builder via comfy-cli skills](https://app.notion.com/p/3c26d73d365081ef9322ca2978e49d3d) ## What lands - **`comfy-cli/comfy-build/SKILL.md`**: one directory, one file, `name:` frontmatter equal to the directory name. A signpost body saying what will fill it and telling an agent not to improvise a build in the meantime, since cutting a version costs the user money. - **A new top-level `comfy-cli/` folder**: skills that comfy-cli's installer fetches, as a sibling of `openclaw/`, which already groups a directory-shaped skill by the host that consumes it. - **`.github/workflows/validate-skills.yml`**: runs the CLI's own `comfy skills validate` over every directory under `comfy-cli/`. The contract lives in the CLI, not restated here. - **README repo layout**: one bullet for `comfy-cli/`, since the layout list is the only place that says where a file belongs. ## Where this sits ```mermaid flowchart LR REPO["comfy-skills · the builder skill's home ◀ this PR"] INST["comfy-cli · the skills installer"] DIRS["agent skill directories<br>Claude Code, Cursor, AGENTS.md"] FIVE["the five bundled skills"] REPO --> INST FIVE --> INST INST --> DIRS classDef out fill:#f5f5f5,stroke:#bbbbbb,stroke-dasharray:4 3,color:#888888; classDef feat fill:#ffe08a,stroke:#b8860b,color:#000; classDef task fill:#ffe08a,stroke:#1a7f37,stroke-width:4px,color:#000; class FIVE,INST,DIRS out class REPO task ``` ## Validation **Local stack, end to end**: comfy-cli 1.16-equivalent from source (`comfy_cli` at `0a6cb6e`), against this working tree: - `comfy skills validate comfy-cli/comfy-build` → `{"valid": true, "name": "comfy-build", "bundled": false}`. - `comfy skills install --scope project --skill <abs path>/comfy-cli/comfy-build` → `wrote` for all three targets: `.claude/skills/comfy-build/SKILL.md`, `.cursor/rules/comfy-build.mdc`, and a `` fence in `AGENTS.md`. **Not run**: the new CI workflow itself, which first executes on this PR, and anything involving a remote fetch, which is the [comfy-cli change](https://app.notion.com/p/3c26d73d365081ba9cefc5fb4cd0c2ab)'s job. ## Departures from the plan <details> <summary>Three, all declared</summary> - **Path moved from `skills/` to `comfy-cli/`.** The plan said `skills/comfy-build/SKILL.md` and called it "first of its kind in the repo". Both are wrong against the repo as it stands: this README documents `skills/` as legacy and frozen pending removal with the `comfy-cloud-mcp` curl installer, and `openclaw/comfy/SKILL.md` is already a directory-shaped skill carrying `name:`/`description:` frontmatter that passes the CLI's contract today. - **No named release.** The plan's deliverable included a tag for the fetch to pin. James chose to pin to `main` instead, so no tag is cut here and the CLI resolves `main` on every install. - **CI validate added.** The plan left this to the task's judgement. Added, because the rule most likely to be got wrong, directory name equals frontmatter `name:`, otherwise fails on a user's machine at install time rather than on the PR that broke it. </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:02 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#20

No description provided.

Rows
Columns