[PR #27] [MERGED] feat(comfy-build): a workflow file is a third way in #26

New issue

Closed

opened 2026-10-26 22:34:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/27
Author: @james00012
Created: 8/25/2026
Status: ✅ Merged
Merged: 8/26/2026
Merged by: @james00012

Base: main ← Head: james/comfy-build-from-workflow

📝 Commits (7)

171d002 feat(comfy-build): a workflow file is a third way in
77150ce fix(comfy-build): say what a 404 from from-workflow means
4016240 fix(comfy-build): six gaps a fresh agent hit on the workflow path
b8f30a0 fix(comfy-build): eight claims the workflow audit disproved
a2d3bf7 fix(comfy-build): take six review findings, and say why two are declined
cbc9d62 fix(comfy-build): quote the class lookup URL
2bb3d7a style(comfy-build): drop an em-dash

📊 Changes

1 file changed (+100 additions, -15 deletions)

View changed files

📝 comfy-cli/comfy-build/SKILL.md (+100 -15)

📄 Description

TL;DR: Teach comfy build from-workflow, so an agent holding only a workflow file has a path in instead of rebuilding by search what the file already names exactly.

Linear: BE-8413

Why: the skill knew three ways to a build and this is the fourth, landed in comfy-cli today. Without it an agent given a workflow file falls through to the description path and searches the registry for topic words while holding the class names.

Validation

Not run: the scenario, and the missing piece is the platform. POST /v1/builds/from-workflow and /v1/workflows/resolve both answer 404 on staging with a token that returns live data from POST /v1/models/resolve, so the verb has nothing to call in any environment I can reach.
Local stack, end to end: two agents driven by the file alone. One took a real SDXL workflow to a hand-written definition after the 404 and reported where the text failed it; one checked every command, flag and field in the new section against merged code. Fourteen defects came back and are fixed here.
Not run: Unit and Integration. This repository has no test suite and a skill file has nothing to execute.

What changed

[comfy-skills] comfy-build/SKILL.md, The path: a workflow shortcut beside the Desktop one. It saves the import report before the first save clears it, checks for the verb rather than a version, gets a yes because the call itself creates, ends at the cut, and says that no model a workflow names reaches the definition.
[comfy-skills] comfy-build/SKILL.md, Reading what comes back: the five report keys only a workflow produces, covering classes nothing provides, classes the registry never answered for, packs with no published version, packs left out for a taken folder, and classes a partner serves.
[comfy-skills] comfy-build/SKILL.md, Find the packs: the class lookup now reads as the route from a workflow, and its 404 is split into core and unknown rather than left ambiguous.

Contradicts: nothing. Two earlier drafts of this branch did bend the file's own rules, recommending a catalog folder as evidence for a model's type and presenting an unpinned repository entry as finished; both are corrected rather than carried.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/27 **Author:** [@james00012](https://github.com/james00012) **Created:** 8/25/2026 **Status:** ✅ Merged **Merged:** 8/26/2026 **Merged by:** [@james00012](https://github.com/james00012) **Base:** `main` ← **Head:** `james/comfy-build-from-workflow` --- ### 📝 Commits (7) - [`171d002`](https://github.com/Comfy-Org/comfy-skills/commit/171d002915043704a37fbec3fa88d15ca1af2447) feat(comfy-build): a workflow file is a third way in - [`77150ce`](https://github.com/Comfy-Org/comfy-skills/commit/77150ce843a5a6368c3fb2844dd51b4ab912d248) fix(comfy-build): say what a 404 from from-workflow means - [`4016240`](https://github.com/Comfy-Org/comfy-skills/commit/40162406df60a316831eb9de0135678c9189411e) fix(comfy-build): six gaps a fresh agent hit on the workflow path - [`b8f30a0`](https://github.com/Comfy-Org/comfy-skills/commit/b8f30a076fc256ab785b5f8fc7e255e1ce0ac504) fix(comfy-build): eight claims the workflow audit disproved - [`a2d3bf7`](https://github.com/Comfy-Org/comfy-skills/commit/a2d3bf7e88d1fd68261a9dc7b75d9376f2e71920) fix(comfy-build): take six review findings, and say why two are declined - [`cbc9d62`](https://github.com/Comfy-Org/comfy-skills/commit/cbc9d626ea606d7e3348cb94dcf9d7110668bb65) fix(comfy-build): quote the class lookup URL - [`2bb3d7a`](https://github.com/Comfy-Org/comfy-skills/commit/2bb3d7acb6a5044a6d9ca86e123848d1743527b7) style(comfy-build): drop an em-dash ### 📊 Changes **1 file changed** (+100 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `comfy-cli/comfy-build/SKILL.md` (+100 -15) </details> ### 📄 Description **TL;DR:** Teach `comfy build from-workflow`, so an agent holding only a workflow file has a path in instead of rebuilding by search what the file already names exactly. Linear: [BE-8413](https://linear.app/comfyorg/issue/BE-8413) **Why:** the skill knew three ways to a build and this is the fourth, landed in comfy-cli today. Without it an agent given a workflow file falls through to the description path and searches the registry for topic words while holding the class names. **Validation** * **Not run**: the scenario, and the missing piece is the platform. `POST /v1/builds/from-workflow` and `/v1/workflows/resolve` both answer `404` on staging with a token that returns live data from `POST /v1/models/resolve`, so the verb has nothing to call in any environment I can reach. * **Local stack, end to end**: two agents driven by the file alone. One took a real SDXL workflow to a hand-written definition after the 404 and reported where the text failed it; one checked every command, flag and field in the new section against merged code. Fourteen defects came back and are fixed here. * **Not run**: Unit and Integration. This repository has no test suite and a skill file has nothing to execute. **What changed** * **[comfy-skills] comfy-build/SKILL.md, The path**: a workflow shortcut beside the Desktop one. It saves the import report before the first save clears it, checks for the verb rather than a version, gets a yes because the call itself creates, ends at the cut, and says that no model a workflow names reaches the definition. * **[comfy-skills] comfy-build/SKILL.md, Reading what comes back**: the five report keys only a workflow produces, covering classes nothing provides, classes the registry never answered for, packs with no published version, packs left out for a taken folder, and classes a partner serves. * **[comfy-skills] comfy-build/SKILL.md, Find the packs**: the class lookup now reads as the route from a workflow, and its `404` is split into core and unknown rather than left ambiguous. **Contradicts:** nothing. Two earlier drafts of this branch did bend the file's own rules, recommending a catalog folder as evidence for a model's `type` and presenting an unpinned `repository` entry as finished; both are corrected rather than carried. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:08 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#26

No description provided.

Rows
Columns