[PR #7] [MERGED] feat(logging): add credential-free os.Logger error logging at SDK catch sites #12

New issue

Closed

opened 2026-10-26 22:33:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:33:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-swift-sdk/pull/7
Author: @mattmillerai
Created: 6/19/2026
Status: ✅ Merged
Merged: 6/19/2026
Merged by: @mattmillerai

Base: main ← Head: matt/be-1608-error-logging-rebased

📝 Commits (1)

175d737 feat(logging): add credential-free os.Logger error logging at SDK catch sites

📊 Changes

5 files changed (+521 additions, -15 deletions)

View changed files

📝 Sources/ComfySwiftSDK/Internal/PollingFallback.swift (+12 -4)
➕ Sources/ComfySwiftSDK/Internal/SDKLog.swift (+214 -0)
📝 Sources/ComfySwiftSDK/Internal/Transport.swift (+14 -8)
📝 Sources/ComfySwiftSDK/Internal/WebSocketSession.swift (+11 -3)
➕ Tests/ComfySwiftSDKTests/LoggingPrivacyTests.swift (+270 -0)

📄 Description

Adds credential-free os.Logger error logging at the SDK's catch/decision sites (transport / websocket / polling), so failures are diagnosable from Console.app — including on TestFlight builds — without standing up a telemetry stack. Error class + POSIX/HTTP code + jobId only; never tokens, keys, request bodies, or output bytes (privacy test enforces this).

Rebased cleanly onto current main, so it sits on top of the output-fetch retry (#3) and reattach retry (#5).

Supersedes #4 — that branch carried a merge commit (it was stacked on #3's commits), which GitHub couldn't squash-merge cleanly. Same content, linear history. swift build + swift test green (134 tests).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-swift-sdk/pull/7 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 6/19/2026 **Status:** ✅ Merged **Merged:** 6/19/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/be-1608-error-logging-rebased` --- ### 📝 Commits (1) - [`175d737`](https://github.com/Comfy-Org/comfy-swift-sdk/commit/175d737ac11fb0129738c8b7fd988bd5a26d4aac) feat(logging): add credential-free os.Logger error logging at SDK catch sites ### 📊 Changes **5 files changed** (+521 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Sources/ComfySwiftSDK/Internal/PollingFallback.swift` (+12 -4) ➕ `Sources/ComfySwiftSDK/Internal/SDKLog.swift` (+214 -0) 📝 `Sources/ComfySwiftSDK/Internal/Transport.swift` (+14 -8) 📝 `Sources/ComfySwiftSDK/Internal/WebSocketSession.swift` (+11 -3) ➕ `Tests/ComfySwiftSDKTests/LoggingPrivacyTests.swift` (+270 -0) </details> ### 📄 Description Adds credential-free `os.Logger` error logging at the SDK's catch/decision sites (transport / websocket / polling), so failures are diagnosable from Console.app — including on TestFlight builds — without standing up a telemetry stack. Error class + POSIX/HTTP code + jobId only; never tokens, keys, request bodies, or output bytes (privacy test enforces this). Rebased cleanly onto current `main`, so it sits on top of the output-fetch retry (#3) and reattach retry (#5). Supersedes #4 — that branch carried a merge commit (it was stacked on #3's commits), which GitHub couldn't squash-merge cleanly. Same content, linear history. `swift build` + `swift test` green (134 tests). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:33:53 +00:00