[GH-ISSUE #171] cursor-review: the github-workflows pin is stale and nothing is moving it #10

New issue

Open

opened 2026-10-31 22:03:41 +00:00 by bsakaguchi · 3 comments

bsakaguchi commented

2026-10-31 22:03:41 +00:00

Owner

Originally created by @github-actions[bot] on GitHub (Sep 21, 2026).
Original GitHub issue: https://github.com/Comfy-Org/comfy-typescript-sdk/issues/171

.github/workflows/ci-cursor-review.yml is pinned to 425c154ce5049324ee23ad10e106baeed4cfa31b, which is
7 consumer-visible commit(s) behind Comfy-Org/github-workflows@main.

	commit	landed
oldest not picked up	`802766b5da2b3c75072044506c98ee217c81b87b`	2026-09-18T00:14:40-07:00
newest upstream (what a bump moves to)	`9bda5abc33f7a8bf99af2b78c79e6e448ab255ce`	2026-09-20T01:18:43-07:00

The oldest one has been sitting there past the 3-day grace window. No PR is open on the ci/bump-cursor-review branch, so nothing is moving the pin.

Things to check, in this order:

Is there a bump PR waiting on a human? If one is named above, it has already
delivered both pins and only the merge is owed -- review and land it, or close it
so this job stops counting it as delivery.
Is this repo still on the bump fleet's roster? The fleet only visits repos
listed in the CURSOR_REVIEW_CALLERS secret on Comfy-Org/github-workflows,
whose canonical copy lives in the private ops repo (deliberately not named here --
this repo is public). A fleet run logs a roster: N caller(s) audit line; if
this repo is missing, add it there and re-dispatch the fleet. That was the
original failure -- a silently dropped roster entry, for three weeks.
Or hand-bump. Move BOTH pins in .github/workflows/ci-cursor-review.yml
(the uses: SHA and the workflows_ref: input) to 9bda5abc33f7a8bf99af2b78c79e6e448ab255ce, update the
trailing # github-workflows main (short) comment, and verify with:
```
node scripts/check-workflow-pins.mjs
```

This issue closes itself on the first daily run that finds the pin moved, or
nothing owed.

Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589137312

Originally created by @github-actions[bot] on GitHub (Sep 21, 2026). Original GitHub issue: https://github.com/Comfy-Org/comfy-typescript-sdk/issues/171 `.github/workflows/ci-cursor-review.yml` is pinned to `425c154ce5049324ee23ad10e106baeed4cfa31b`, which is **7 consumer-visible commit(s) behind `Comfy-Org/github-workflows@main`**. | | commit | landed | | --- | --- | --- | | oldest not picked up | `802766b5da2b3c75072044506c98ee217c81b87b` | 2026-09-18T00:14:40-07:00 | | newest upstream (what a bump moves to) | `9bda5abc33f7a8bf99af2b78c79e6e448ab255ce` | 2026-09-20T01:18:43-07:00 | The oldest one has been sitting there past the 3-day grace window. No PR is open on the `ci/bump-cursor-review` branch, so nothing is moving the pin. Things to check, in this order: 1. **Is there a bump PR waiting on a human?** If one is named above, it has already delivered both pins and only the merge is owed -- review and land it, or close it so this job stops counting it as delivery. 2. **Is this repo still on the bump fleet's roster?** The fleet only visits repos listed in the `CURSOR_REVIEW_CALLERS` secret on `Comfy-Org/github-workflows`, whose canonical copy lives in the private ops repo (deliberately not named here -- this repo is public). A fleet run logs a `roster: N caller(s)` audit line; if this repo is missing, add it there and re-dispatch the fleet. That was the original failure -- a silently dropped roster entry, for three weeks. 3. **Or hand-bump.** Move BOTH pins in `.github/workflows/ci-cursor-review.yml` (the `uses:` SHA and the `workflows_ref:` input) to `9bda5abc33f7a8bf99af2b78c79e6e448ab255ce`, update the trailing `# github-workflows main (short)` comment, and verify with: node scripts/check-workflow-pins.mjs This issue closes itself on the first daily run that finds the pin moved, or nothing owed. Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589137312

bsakaguchi added the

cursor-review-pin

label

2026-10-31 22:03:41 +00:00

bsakaguchi commented

2026-10-31 22:03:42 +00:00

Author

Owner

@github-actions[bot] commented on GitHub (Sep 21, 2026):

Nothing is overdue any more. The pin is still 7 consumer-visible commit(s) behind Comfy-Org/github-workflows@main, but the oldest one it has not picked up (802766b5da2b3c75072044506c98ee217c81b87b) landed inside the 3-day grace window, so this issue's premise -- a pin sitting frozen PAST that window -- no longer holds. But the pin is still 425c154ce5049324ee23ad10e106baeed4cfa31b -- the same value recorded on the last stale report -- so the backlog shrank without the pin moving. The likeliest cause is upstream narrowing WATCHED_PATHSPECS in Comfy-Org/github-workflows@main:.github/workflows/bump-cursor-review-callers.yml, which this job re-reads live on every run: fewer watched paths means fewer owed commits, on a pin nothing has touched. So this issue stays OPEN -- it closes when the pin actually moves, or when nothing is owed at all.

Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589289709

@github-actions[bot] commented on GitHub (Sep 21, 2026): Nothing is overdue any more. The pin is still 7 consumer-visible commit(s) behind `Comfy-Org/github-workflows@main`, but the oldest one it has not picked up (`802766b5da2b3c75072044506c98ee217c81b87b`) landed inside the 3-day grace window, so this issue's premise -- a pin sitting frozen PAST that window -- no longer holds. But the pin is still `425c154ce5049324ee23ad10e106baeed4cfa31b` -- the same value recorded on the last stale report -- so the backlog shrank without the pin moving. The likeliest cause is upstream narrowing `WATCHED_PATHSPECS` in `Comfy-Org/github-workflows@main:.github/workflows/bump-cursor-review-callers.yml`, which this job re-reads live on every run: fewer watched paths means fewer owed commits, on a pin nothing has touched. So this issue stays OPEN -- it closes when the pin actually moves, or when nothing is owed at all. Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589289709

bsakaguchi commented

2026-10-31 22:03:42 +00:00

Author

Owner

@github-actions[bot] commented on GitHub (Sep 21, 2026):

Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589391062

@github-actions[bot] commented on GitHub (Sep 21, 2026): Nothing is overdue any more. The pin is still 7 consumer-visible commit(s) behind `Comfy-Org/github-workflows@main`, but the oldest one it has not picked up (`802766b5da2b3c75072044506c98ee217c81b87b`) landed inside the 3-day grace window, so this issue's premise -- a pin sitting frozen PAST that window -- no longer holds. The pin moved from `425c154ce5049324ee23ad10e106baeed4cfa31b` to `ebfd9e44588ffc560a063d0d13cf8a9a91d1ffb0` since the last stale report, so a bump landed. It reopens on the first daily run that finds the pin frozen past the grace window again. Run: https://github.com/Comfy-Org/comfy-typescript-sdk/actions/runs/35589391062

bsakaguchi commented

2026-10-31 22:03:42 +00:00

Author

Owner

@mattmillerai commented on GitHub (Sep 21, 2026):

Housekeeping: the close directly above came from a scratch branch that had the caller pin temporarily rewritten to an older SHA, purely to exercise the grace close path on a branch run. The pin has not actually moved -- this repo is still pinned to 425c154ce5049324ee23ad10e106baeed4cfa31b and the backlog above is real -- so reopening.

The two grace comments before this one, and the 1 year grace window they were judged against, are likewise from those scratch branches and not from a scheduled run.

@mattmillerai commented on GitHub (Sep 21, 2026): Housekeeping: the close directly above came from a scratch branch that had the caller pin temporarily rewritten to an older SHA, purely to exercise the `grace` close path on a branch run. The pin has not actually moved -- this repo is still pinned to `425c154ce5049324ee23ad10e106baeed4cfa31b` and the backlog above is real -- so reopening. The two `grace` comments before this one, and the `1 year` grace window they were judged against, are likewise from those scratch branches and not from a scheduled run.

bsakaguchi referenced this issue

2026-10-31 22:03:53 +00:00

[PR #10] [CLOSED] chore: sync vendored Comfy API v2 spec (cloud@3ac2853) #20