[PR #113] [MERGED] docs(readme): absolute URL for the logo #115

New issue

Closed

opened 2026-10-31 22:04:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:04:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-typescript-sdk/pull/113
Author: @mattmillerai
Created: 9/1/2026
Status: ✅ Merged
Merged: 9/1/2026
Merged by: @mattmillerai

Base: main ← Head: matt/npm-readme-absolute-logo

📝 Commits (2)

50a936d docs(readme): absolute URL for the logo
2d6e2a7 docs(readme): pin the logo URL to a commit SHA

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 README.md (+4 -1)

📄 Description

npmjs.com rewrites relative markdown links against the repository field but not raw HTML <img> tags, so the repo-relative assets/logo.svg shows as a broken image on the package page. raw.githubusercontent.com serves the SVG as image/svg+xml, so an absolute URL renders on npm and GitHub alike.

The registry page picks this up at the next release — the published v0.1.8 page keeps its snapshot.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-typescript-sdk/pull/113 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 9/1/2026 **Status:** ✅ Merged **Merged:** 9/1/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/npm-readme-absolute-logo` --- ### 📝 Commits (2) - [`50a936d`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/50a936dbb0e78f9eacff88e79b5928096fa37ac3) docs(readme): absolute URL for the logo - [`2d6e2a7`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/2d6e2a7e7bdb02d327979633afe6f1890a6bf97a) docs(readme): pin the logo URL to a commit SHA ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -1) </details> ### 📄 Description npmjs.com rewrites relative markdown links against the `repository` field but not raw HTML `<img>` tags, so the repo-relative `assets/logo.svg` shows as a broken image on [the package page](https://www.npmjs.com/package/@comfyorg/sdk). `raw.githubusercontent.com` serves the SVG as `image/svg+xml`, so an absolute URL renders on npm and GitHub alike. The registry page picks this up at the next release — the published v0.1.8 page keeps its snapshot. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:04:40 +00:00