[PR #134] [MERGED] ci: fail the PR check while a do-not-merge label is present #136

New issue

Closed

opened 2026-10-31 22:04:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:04:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-typescript-sdk/pull/134
Author: @mattmillerai
Created: 9/10/2026
Status: ✅ Merged
Merged: 9/10/2026
Merged by: @mattmillerai

Base: main ← Head: matt/ci-block-do-not-merge

📝 Commits (1)

8ed67e0 ci: fail the PR check while a do-not-merge label is present

📊 Changes

1 file changed (+37 additions, -0 deletions)

View changed files

➕ .github/workflows/ci-block-do-not-merge.yml (+37 -0)

📄 Description

ELI-5

Some PRs are finished but must not land yet, because the server side they talk to is not deployed. Putting a do-not-merge label on such a PR now turns one CI check red, so nobody merges it by accident. Take the label off and the check goes green.

What

New workflow CI - Block do-not-merge: fails whenever the PR carries the do-not-merge label, passes otherwise. Runs on open, reopen, push, label and unlabel, so the check exists on every PR.
Same shape as the check the cloud repo uses, with the added triggers so it posts on every PR rather than only on label changes.

Why now

The queue (submit / subscribe / handle) SDK PR is complete but the /requests routes it calls are only on a Comfy Cloud feature branch, so releasing it today would break callers. The label is on that PR already; this makes it visible in CI.

Making it a hard block

Mark Block do-not-merge as a required status check in branch protection. Until then the red check is advisory.

Testing

Workflow is a single jq test on the event payload, mirrored from the cloud repo where it has run for months. It can be exercised on this PR by adding and removing the label.

Summary by CodeRabbit

Chores
- Added an automated pull request check that blocks merging when the “do-not-merge” label is applied.
- The check explains how to unblock the pull request; unlabeled pull requests pass normally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-typescript-sdk/pull/134 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 9/10/2026 **Status:** ✅ Merged **Merged:** 9/10/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/ci-block-do-not-merge` --- ### 📝 Commits (1) - [`8ed67e0`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/8ed67e0e7eb5476df57dc87638598c2313559006) ci: fail the PR check while a do-not-merge label is present ### 📊 Changes **1 file changed** (+37 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/ci-block-do-not-merge.yml` (+37 -0) </details> ### 📄 Description ## ELI-5 Some PRs are finished but must not land yet, because the server side they talk to is not deployed. Putting a `do-not-merge` label on such a PR now turns one CI check red, so nobody merges it by accident. Take the label off and the check goes green. ## What - New workflow `CI - Block do-not-merge`: fails whenever the PR carries the `do-not-merge` label, passes otherwise. Runs on open, reopen, push, label and unlabel, so the check exists on every PR. - Same shape as the check the cloud repo uses, with the added triggers so it posts on every PR rather than only on label changes. ## Why now The queue (`submit` / `subscribe` / `handle`) SDK PR is complete but the `/requests` routes it calls are only on a Comfy Cloud feature branch, so releasing it today would break callers. The label is on that PR already; this makes it visible in CI. ## Making it a hard block Mark `Block do-not-merge` as a required status check in branch protection. Until then the red check is advisory. ## Testing Workflow is a single `jq` test on the event payload, mirrored from the cloud repo where it has run for months. It can be exercised on this PR by adding and removing the label.  ## Summary by CodeRabbit * **Chores** * Added an automated pull request check that blocks merging when the “do-not-merge” label is applied. * The check explains how to unblock the pull request; unlabeled pull requests pass normally.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:04:55 +00:00