[PR #28] [MERGED] chore: ship source maps and declare sideEffects for the published package #36

New issue

Closed

opened 2026-10-31 22:04:02 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:04:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-typescript-sdk/pull/28
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @wei-hai

Base: main ← Head: chore/publish-build-output

📝 Commits (1)

0ad9d1a chore: ship source maps and declare sideEffects for the published package

📊 Changes

2 files changed (+7 additions, -2 deletions)

View changed files

📝 package.json (+4 -1)
📝 tsconfig.json (+3 -1)

📄 Description

Two gaps in what consumers get from the tarball. There were no source maps, so stepping into the SDK from a debugger landed in compiled output with no way back to the TypeScript, and "go to definition" stopped at the .d.ts; emitting sourceMap/declarationMap and shipping src/ (tests excluded via a negated files pattern) fixes both. And there was no sideEffects flag, so bundlers had to assume every module might do work on import and couldn't tree-shake unused ones.

I verified sideEffects: false is actually accurate — no module has a top-level side-effecting statement; the module-level values are pure constructions (Set, Symbol, zod schemas). Also verified every sources entry in the packed tarball resolves to a file present in it. Tarball goes 44K → 76K.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-typescript-sdk/pull/28 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@wei-hai](https://github.com/wei-hai) **Base:** `main` ← **Head:** `chore/publish-build-output` --- ### 📝 Commits (1) - [`0ad9d1a`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/0ad9d1a23c63f6f73411020b75f5f088eb677de5) chore: ship source maps and declare sideEffects for the published package ### 📊 Changes **2 files changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+4 -1) 📝 `tsconfig.json` (+3 -1) </details> ### 📄 Description Two gaps in what consumers get from the tarball. There were no source maps, so stepping into the SDK from a debugger landed in compiled output with no way back to the TypeScript, and "go to definition" stopped at the `.d.ts`; emitting `sourceMap`/`declarationMap` and shipping `src/` (tests excluded via a negated `files` pattern) fixes both. And there was no `sideEffects` flag, so bundlers had to assume every module might do work on import and couldn't tree-shake unused ones. I verified `sideEffects: false` is actually accurate — no module has a top-level side-effecting statement; the module-level values are pure constructions (Set, Symbol, zod schemas). Also verified every `sources` entry in the packed tarball resolves to a file present in it. Tarball goes 44K → 76K. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:04:02 +00:00