[PR #39] [MERGED] docs: present per-deployment subdomains as the gateway's URL shape #49

New issue

Closed

opened 2026-10-31 22:04:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:04:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-typescript-sdk/pull/39
Author: @sundar-svg
Created: 8/4/2026
Status: ✅ Merged
Merged: 8/4/2026
Merged by: @sundar-svg

Base: main ← Head: sundar-svg/subdomain-url-docs

📝 Commits (2)

cc7abf4 docs: present per-deployment subdomains as the gateway's URL shape
c1e53fb style: oxfmt

📊 Changes

1 file changed (+20 additions, -13 deletions)

View changed files

📝 src/low/followUpLinks.test.ts (+20 -13)

📄 Description

Description

Comfy Cloud deployments now serve on per-deployment subdomains (https://{dep_id}.run.comfy.app); the path-mounted gateway shape is being retired. Test/docs cleanup only — no client code changes (the SDK is base-URL-agnostic and already works with both shapes):

followUpLinks.test.ts: doc comment reframed (subdomain is the current gateway shape; origin-resolution stays pinned for any path-carrying base, e.g. a proxy mount), fixture renamed PATH_MOUNTED_BASE with a neutral example host, and a new subdomain-base case covering the modern shape.

How tested

vitest run src/low/followUpLinks.test.ts — 5 passed (4 existing + 1 new).

🤖 Generated with Claude Code

https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm

Summary by CodeRabbit

Tests
- Expanded coverage for follow-up links in subdomain and path-mounted deployments.
- Verified deployment prefixes are preserved for shorthand paths.
- Continued validating authorization for links resolved against the origin.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-typescript-sdk/pull/39 **Author:** [@sundar-svg](https://github.com/sundar-svg) **Created:** 8/4/2026 **Status:** ✅ Merged **Merged:** 8/4/2026 **Merged by:** [@sundar-svg](https://github.com/sundar-svg) **Base:** `main` ← **Head:** `sundar-svg/subdomain-url-docs` --- ### 📝 Commits (2) - [`cc7abf4`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/cc7abf4db13b200406c4bc512bc2aac43bd45001) docs: present per-deployment subdomains as the gateway's URL shape - [`c1e53fb`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/c1e53fb765cc1af3b0a2a7f66fa59d2a574c0947) style: oxfmt ### 📊 Changes **1 file changed** (+20 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/low/followUpLinks.test.ts` (+20 -13) </details> ### 📄 Description ## Description Comfy Cloud deployments now serve on per-deployment subdomains (`https://{dep_id}.run.comfy.app`); the path-mounted gateway shape is being retired. Test/docs cleanup only — no client code changes (the SDK is base-URL-agnostic and already works with both shapes): - `followUpLinks.test.ts`: doc comment reframed (subdomain is the current gateway shape; origin-resolution stays pinned for any path-carrying base, e.g. a proxy mount), fixture renamed `PATH_MOUNTED_BASE` with a neutral example host, and a new subdomain-base case covering the modern shape. ## How tested `vitest run src/low/followUpLinks.test.ts` — 5 passed (4 existing + 1 new). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm  ## Summary by CodeRabbit * **Tests** * Expanded coverage for follow-up links in subdomain and path-mounted deployments. * Verified deployment prefixes are preserved for shorthand paths. * Continued validating authorization for links resolved against the origin.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:04:07 +00:00