[PR #35] [CLOSED] ci: move frontend container bumps to ComfyUI_frontend #34

New issue

Closed

opened 2026-10-26 22:23:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:23:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyui-ci-container/pull/35
Author: @DrJKL
Created: 10/1/2026
Status: ❌ Closed

Base: main ← Head: drjkl/frontend-owns-container-bump

📝 Commits (2)

38ec99d ci: move frontend container bumps to ComfyUI_frontend
0cf9448 docs: run the frontend container update on demand

📊 Changes

4 files changed (+8 additions, -238 deletions)

View changed files

📝 .agents/skills/updating-ci-container/SKILL.md (+2 -2)
📝 .github/workflows/build-and-push.yml (+0 -14)
➖ .github/workflows/update-frontend-container-ref.yml (+0 -220)
📝 .github/workflows/update-playwright.yml (+6 -2)

📄 Description

Summary

Stop opening ComfyUI_frontend PRs from this repo. FRONTEND_PAT no longer works, and no org-level token or GitHub App secret is shared with this repo. Comfy-Org/ComfyUI_frontend#19692 adds a workflow in the frontend repo that does the same job with that repo's own tokens.

Changes

Delete update-frontend-container-ref.yml, and remove the update-frontend job and the unused build.outputs.version from build-and-push.yml
update-playwright.yml opens its PR (in this repo) with GITHUB_TOKEN instead of FRONTEND_PAT
Update the PR body text and the updating-ci-container skill to describe the new flow, which bumps @playwright/test automatically

Before merging

Merge Comfy-Org/ComfyUI_frontend#19692 first, so a container release is never left without a frontend bump.
update-playwright.yml needs Settings → Actions → General → Allow GitHub Actions to create and approve pull requests turned on. It is currently off. Without it, the PR step fails, though the branch still gets pushed.
When this merges, nothing references FRONTEND_PAT, so the repo secret can be deleted.

actionlint passes on all workflows.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyui-ci-container/pull/35 **Author:** [@DrJKL](https://github.com/DrJKL) **Created:** 10/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `drjkl/frontend-owns-container-bump` --- ### 📝 Commits (2) - [`38ec99d`](https://github.com/Comfy-Org/comfyui-ci-container/commit/38ec99d44ba2e5677ba5e1bfe3cff329cabbe9ec) ci: move frontend container bumps to ComfyUI_frontend - [`0cf9448`](https://github.com/Comfy-Org/comfyui-ci-container/commit/0cf94483d525081599ac8a9d87db03a8543b3af0) docs: run the frontend container update on demand ### 📊 Changes **4 files changed** (+8 additions, -238 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/updating-ci-container/SKILL.md` (+2 -2) 📝 `.github/workflows/build-and-push.yml` (+0 -14) ➖ `.github/workflows/update-frontend-container-ref.yml` (+0 -220) 📝 `.github/workflows/update-playwright.yml` (+6 -2) </details> ### 📄 Description ## Summary Stop opening ComfyUI_frontend PRs from this repo. `FRONTEND_PAT` no longer works, and no org-level token or GitHub App secret is shared with this repo. Comfy-Org/ComfyUI_frontend#19692 adds a workflow in the frontend repo that does the same job with that repo's own tokens. ## Changes - Delete `update-frontend-container-ref.yml`, and remove the `update-frontend` job and the unused `build.outputs.version` from `build-and-push.yml` - `update-playwright.yml` opens its PR (in this repo) with `GITHUB_TOKEN` instead of `FRONTEND_PAT` - Update the PR body text and the `updating-ci-container` skill to describe the new flow, which bumps `@playwright/test` automatically ## Before merging - Merge Comfy-Org/ComfyUI_frontend#19692 first, so a container release is never left without a frontend bump. - `update-playwright.yml` needs **Settings → Actions → General → Allow GitHub Actions to create and approve pull requests** turned on. It is currently off. Without it, the PR step fails, though the branch still gets pushed. - When this merges, nothing references `FRONTEND_PAT`, so the repo secret can be deleted. `actionlint` passes on all workflows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:23:07 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfyui-ci-container#34

No description provided.

Rows
Columns