[PR #671] [MERGED] Fix duplication in window closed logic #1009

New issue

Closed

opened 2026-10-31 22:18:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/671
Author: @webfiltered
Created: 1/20/2025
Status: ✅ Merged
Merged: 1/20/2025
Merged by: @webfiltered

Base: main ← Head: fix-window-close-logic

📝 Commits (1)

cd98107 Fix duplication in window closed logic

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 src/main.ts (+1 -5)

📄 Description

Removes redundant handling of window close.
Prevents app quit when replacing the current window
Prevents app quit when closing any second window

Logs from normal, single window close with this PR:

04:46:04.631 > App window closed.
04:46:04.657 > Window all closed
04:46:04.659 > Quitting ComfyUI because window all closed
04:46:04.659 > Before-quit: Killing Python server
04:46:04.660 > Killing ComfyUI python server.
04:46:04.665 > Python process exited with code null and signal SIGTERM
04:46:04.666 > Python server exited with code null and signal SIGTERM

Process exits with code 0.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/671 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/20/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-window-close-logic` --- ### 📝 Commits (1) - [`cd98107`](https://github.com/Comfy-Org/desktop/commit/cd98107e944f86cc847a06a074c52237e526fe07) Fix duplication in window closed logic ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+1 -5) </details> ### 📄 Description - Removes redundant handling of window close. - Prevents app quit when replacing the current window - Prevents app quit when closing any second window Logs from normal, single window close with this PR: ``` 04:46:04.631 > App window closed. 04:46:04.657 > Window all closed 04:46:04.659 > Quitting ComfyUI because window all closed 04:46:04.659 > Before-quit: Killing Python server 04:46:04.660 > Killing ComfyUI python server. 04:46:04.665 > Python process exited with code null and signal SIGTERM 04:46:04.666 > Python server exited with code null and signal SIGTERM ``` Process exits with code 0. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-671-Fix-duplication-in-window-closed-logic-1816d73d365081ada836ff69ebef14f1) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:46 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:05 +00:00

[PR #1009] [MERGED] Increase size limit for ToDesktop uploads. #1282

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1009

No description provided.

Rows
Columns