[PR #679] [MERGED] [Test] Add ComfyServerConfig unit tests #1015

New issue

Closed

opened 2026-10-31 22:18:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/679
Author: @christian-byrne
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/server-config

📝 Commits (4)

2d62e6f Add unit tests for comfy server config
3d2d64a refactor
7bd439a refactor
96845b1 fix yaml lint

📊 Changes

7 files changed (+210 additions, -42 deletions)

View changed files

➕ tests/assets/extra_models_paths/legacy-format.yaml (+5 -0)
➕ tests/assets/extra_models_paths/malformed.yaml (+4 -0)
➕ tests/assets/extra_models_paths/missing-base-path.yaml (+3 -0)
➕ tests/assets/extra_models_paths/multiple-sections.yaml (+12 -0)
➕ tests/assets/extra_models_paths/valid-config.yaml (+8 -0)
➕ tests/assets/extra_models_paths/wrong-type.yaml (+2 -0)
📝 tests/unit/comfyServerConfig.test.ts (+176 -42)

📄 Description

Extends unit tests on ComfyServerConfig to include methods:

generateConfigFileContent
getBaseModelPathFromRepoPath
getBaseConfig
readConfigFile

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/679 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/server-config` --- ### 📝 Commits (4) - [`2d62e6f`](https://github.com/Comfy-Org/desktop/commit/2d62e6ff8a9a44471c347566776b8930c0280a1a) Add unit tests for comfy server config - [`3d2d64a`](https://github.com/Comfy-Org/desktop/commit/3d2d64a550735533e133cc3fc2be744354a5f1f4) refactor - [`7bd439a`](https://github.com/Comfy-Org/desktop/commit/7bd439a13744afeb159de657380478b9b354e788) refactor - [`96845b1`](https://github.com/Comfy-Org/desktop/commit/96845b107c02d2c807505bada0aa5dfb3a4df38d) fix yaml lint ### 📊 Changes **7 files changed** (+210 additions, -42 deletions) <details> <summary>View changed files</summary> ➕ `tests/assets/extra_models_paths/legacy-format.yaml` (+5 -0) ➕ `tests/assets/extra_models_paths/malformed.yaml` (+4 -0) ➕ `tests/assets/extra_models_paths/missing-base-path.yaml` (+3 -0) ➕ `tests/assets/extra_models_paths/multiple-sections.yaml` (+12 -0) ➕ `tests/assets/extra_models_paths/valid-config.yaml` (+8 -0) ➕ `tests/assets/extra_models_paths/wrong-type.yaml` (+2 -0) 📝 `tests/unit/comfyServerConfig.test.ts` (+176 -42) </details> ### 📄 Description Extends unit tests on `ComfyServerConfig` to include methods: - `generateConfigFileContent` - `getBaseModelPathFromRepoPath` - `getBaseConfig` - `readConfigFile` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-679-Test-Add-ComfyServerConfig-unit-tests-1826d73d365081678f6af5b168f3111f) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:48 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:07 +00:00

[PR #1015] [MERGED] Frontend v1.10.18 #1287

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1015

No description provided.

Rows
Columns