[PR #690] [MERGED] Fixed: Quit app on mac when windows are closed. #1019

New issue

Closed

opened 2026-10-31 22:18:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/690
Author: @robinjhuang
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @huchenlei

Base: main ← Head: rh-mac

📝 Commits (1)

04d4031 Quit app on mac when windows are closed.

📊 Changes

1 file changed (+2 additions, -5 deletions)

View changed files

📝 src/main.ts (+2 -5)

📄 Description

Currently, when we close the app window you can re-open it from the mac doc. Which shows this error since the AppWindow is already destroyed.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/690 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `rh-mac` --- ### 📝 Commits (1) - [`04d4031`](https://github.com/Comfy-Org/desktop/commit/04d40313a6e46bda91412b6a28d50bdf86f317e0) Quit app on mac when windows are closed. ### 📊 Changes **1 file changed** (+2 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+2 -5) </details> ### 📄 Description Currently, when we close the app window you can re-open it from the mac doc. Which shows this error since the AppWindow is already destroyed. <img width="259" alt="Screenshot 2025-01-21 at 3 30 20 PM" src="https://github.com/user-attachments/assets/d5fb1906-6fca-4f47-a3ec-332a4c7fa83e" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-690-Fixed-Quit-app-on-mac-when-windows-are-closed-1826d73d365081ea8916ca5304a75797) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:09 +00:00

[PR #1019] [MERGED] Update ComfyUI to v0.3.21 #1289

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1019

No description provided.

Rows
Columns