[PR #691] [MERGED] [Test] Add unit tests for 100% coverage of comfyServerConfig #1022

New issue

Closed

opened 2026-10-31 22:18:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/691
Author: @christian-byrne
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/server-config-p2

📝 Commits (3)

8e18b3d add tests on remaining branches (non-deprecated) functions in comfyServerConfig
eb201c5 expect log error
5cab8fa remove comments

📊 Changes

1 file changed (+83 additions, -1 deletions)

View changed files

📝 tests/unit/comfyServerConfig.test.ts (+83 -1)

📄 Description

This PR adds unit tests on remaining branches in comfyServerConfig, bringing to 100% coverage:

The untested function is marked as deprecated and never called.

Newly tested functions are:

exists
writeConfigFile
createConfigFile
getConfigFile
getConfigFromRepoPath
Test for final untested branch in readBasePathFromConfig

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/691 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/server-config-p2` --- ### 📝 Commits (3) - [`8e18b3d`](https://github.com/Comfy-Org/desktop/commit/8e18b3d7502d1c3314f97fe8c68439688b6cb8fe) add tests on remaining branches (non-deprecated) functions in comfyServerConfig - [`eb201c5`](https://github.com/Comfy-Org/desktop/commit/eb201c5406396cf6d9108c03c155830843b7b2d7) expect log error - [`5cab8fa`](https://github.com/Comfy-Org/desktop/commit/5cab8fab21897efef00eace95884260f6ddacd12) remove comments ### 📊 Changes **1 file changed** (+83 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/comfyServerConfig.test.ts` (+83 -1) </details> ### 📄 Description This PR adds unit tests on remaining branches in `comfyServerConfig`, bringing to 100% coverage: ![Selection_790](https://github.com/user-attachments/assets/381ec13f-3d06-45b6-9983-022e47bea22c) The untested function is marked as deprecated and never called. Newly tested functions are: - `exists` - `writeConfigFile` - `createConfigFile` - `getConfigFile` - `getConfigFromRepoPath` - Test for final untested branch in `readBasePathFromConfig` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-691-Test-Add-unit-tests-for-100-coverage-of-comfyServerConfig-1826d73d3650810b89f6c12875e7016a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:10 +00:00

[PR #1022] [MERGED] Update ComfyUI to v0.3.22 #1292

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1022

No description provided.

Rows
Columns