[PR #696] [MERGED] [Test] Add test on window close #1027

New issue

Closed

opened 2026-10-31 22:18:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/696
Author: @christian-byrne
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: test/window-close-quit

📝 Commits (6)

24939d9 test playwright window close
9c29860 refactor
51124c0 remove describe
852044a verify if test fails prior to change
1ec5d84 verify if test fails prior to change
c66efef revert debug change

📊 Changes

1 file changed (+12 additions, -2 deletions)

View changed files

📝 tests/integration/appLifecycle.spec.ts (+12 -2)

📄 Description

Adds playwright test to ensure the app quits when the window is closed.

The test run from this commit verified that the test fails prior to the change in https://github.com/Comfy-Org/desktop/pull/690

Ref:

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/696 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `test/window-close-quit` --- ### 📝 Commits (6) - [`24939d9`](https://github.com/Comfy-Org/desktop/commit/24939d9531e2939fee849473d2dd8cc91ac57585) test playwright window close - [`9c29860`](https://github.com/Comfy-Org/desktop/commit/9c298605ddf436de619eb195fe2e4a32f107f09c) refactor - [`51124c0`](https://github.com/Comfy-Org/desktop/commit/51124c0afba4729014205352ea13a9d5613b7650) remove describe - [`852044a`](https://github.com/Comfy-Org/desktop/commit/852044a1fdcf4faae82cdcdc0a38ebef10582c36) verify if test fails prior to change - [`1ec5d84`](https://github.com/Comfy-Org/desktop/commit/1ec5d84a9d9460d871a815d7951fab61f74c87d1) verify if test fails prior to change - [`c66efef`](https://github.com/Comfy-Org/desktop/commit/c66efef2497078b901d7e61fddb3764accd11e23) revert debug change ### 📊 Changes **1 file changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/appLifecycle.spec.ts` (+12 -2) </details> ### 📄 Description Adds playwright test to ensure the app quits when the window is closed. The [test run](https://github.com/Comfy-Org/desktop/actions/runs/12919313117/job/36029573714) from [this commit](https://github.com/Comfy-Org/desktop/pull/696/commits/1ec5d84a9d9460d871a815d7951fab61f74c87d1) verified that the test fails prior to the change in https://github.com/Comfy-Org/desktop/pull/690 Ref: - https://github.com/Comfy-Org/desktop/pull/690 - [Error Report](https://comfy-org.sentry.io/issues/6234169809/?alert_rule_id=15469165&alert_timestamp=1737459084819&alert_type=email&environment=production&notification_uuid=55a41e95-050b-4e16-a0c4-26e3b43a062e&project=4508007940685824) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-696-Test-Add-test-on-window-close-1836d73d365081eb9782f3581f2f629a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:54 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:13 +00:00

[PR #1027] [MERGED] Update ComfyUI to v0.3.23 #1296

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1027

No description provided.

Rows
Columns