[PR #702] [MERGED] Update ESLint rules #1032

New issue

Closed

opened 2026-10-31 22:18:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/702
Author: @christian-byrne
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @huchenlei

Base: main ← Head: linting-rule

📝 Commits (3)

039915e update es-lint rules
cca391a re-add comment
1e9908c apply last no-unsafe- rule to test files

📊 Changes

4 files changed (+8 additions, -15 deletions)

View changed files

📝 eslint.config.js (+7 -0)
📝 tests/unit/comfySettings.test.ts (+0 -2)
📝 tests/unit/telemetry.test.ts (+1 -11)
📝 tests/unit/utils.test.ts (+0 -2)

📄 Description

Updates es-lint rules:

Disable no-unsafe-* and no-explicit-any rules in test files as it is often necessary to mock objects and functions, which can require using any types or unsafe assignments/accesses
Enable prefer-readonly (ref: https://github.com/Comfy-Org/desktop/pull/697)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/702 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `linting-rule` --- ### 📝 Commits (3) - [`039915e`](https://github.com/Comfy-Org/desktop/commit/039915e099c9c0765cd44fa8ac03b4e2df01ed05) update es-lint rules - [`cca391a`](https://github.com/Comfy-Org/desktop/commit/cca391a2b5739aed353167cee49ba4496339afaf) re-add comment - [`1e9908c`](https://github.com/Comfy-Org/desktop/commit/1e9908cad26349323922c577d82ef44463c48bf5) apply last no-unsafe- rule to test files ### 📊 Changes **4 files changed** (+8 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.js` (+7 -0) 📝 `tests/unit/comfySettings.test.ts` (+0 -2) 📝 `tests/unit/telemetry.test.ts` (+1 -11) 📝 `tests/unit/utils.test.ts` (+0 -2) </details> ### 📄 Description Updates es-lint rules: - Disable no-unsafe-* and no-explicit-any rules in test files as it is often necessary to mock objects and functions, which can require using any types or unsafe assignments/accesses - Enable [prefer-readonly](https://typescript-eslint.io/rules/prefer-readonly/) (ref: https://github.com/Comfy-Org/desktop/pull/697) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-702-Update-ESLint-rules-1846d73d36508193a94edad0127d7736) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:56 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1032

No description provided.

Rows
Columns