[PR #706] [MERGED] [Test] Add unit tests on handlers #1034

New issue

Closed

opened 2026-10-31 22:18:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/706
Author: @christian-byrne
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/handlers

📝 Commits (5)

87292c5 add unit tests for app info handlers
59b019b refactor
47c2a1f refactor appInfoHandler tests
41cdac2 add unit test on quit handler
8d0e757 refactor

📊 Changes

2 files changed (+161 additions, -8 deletions)

View changed files

➕ tests/unit/handlers/AppHandlers.test.ts (+67 -0)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+94 -8)

📄 Description

This PR adds unit tests on all modules in src/handlers:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/706 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/handlers` --- ### 📝 Commits (5) - [`87292c5`](https://github.com/Comfy-Org/desktop/commit/87292c599a603f82cdaab00ab9e2981fb01aad6b) add unit tests for app info handlers - [`59b019b`](https://github.com/Comfy-Org/desktop/commit/59b019b00678377d5d33125a411190fae51b6d56) refactor - [`47c2a1f`](https://github.com/Comfy-Org/desktop/commit/47c2a1fb2332f49ee6066edfb08957e910d1baa9) refactor appInfoHandler tests - [`41cdac2`](https://github.com/Comfy-Org/desktop/commit/41cdac2a9d0c4bf5379901d95dab32bb13fb4868) add unit test on quit handler - [`8d0e757`](https://github.com/Comfy-Org/desktop/commit/8d0e757c21b25feb25faa0e6f5fdde8bd8050a5a) refactor ### 📊 Changes **2 files changed** (+161 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `tests/unit/handlers/AppHandlers.test.ts` (+67 -0) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+94 -8) </details> ### 📄 Description This PR adds unit tests on all modules in `src/handlers`: ![Selection_794](https://github.com/user-attachments/assets/0ebe182a-8c95-4c0f-810e-fcc3e4aca9f1) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:59 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:13 +00:00

[PR #1034] [MERGED] Update Frontend v1.11.8 #1295

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1034

No description provided.

Rows
Columns