[PR #712] [MERGED] [Test] Add install validation unit tests #1039

New issue

Closed

opened 2026-10-31 22:19:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/712
Author: @christian-byrne
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/installManager

📝 Commits (4)

ea37b35 add ensureInstalled unit tests
a4f58d5 refactor
b93adc6 refactor
866b2cd refactor

📊 Changes

1 file changed (+189 additions, -0 deletions)

View changed files

➕ tests/unit/install/installationManager.test.ts (+189 -0)

📄 Description

This PR adds unit tests on installationManager ensureInstalled method, testing various installation validation scenarios.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/712 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/installManager` --- ### 📝 Commits (4) - [`ea37b35`](https://github.com/Comfy-Org/desktop/commit/ea37b35fe4b2deac15c5ba7d5dcd52bc080caa9c) add ensureInstalled unit tests - [`a4f58d5`](https://github.com/Comfy-Org/desktop/commit/a4f58d5b4c5d3a1355c76a0a16206f0a6799bd4f) refactor - [`b93adc6`](https://github.com/Comfy-Org/desktop/commit/b93adc6dc9b99c51fbc952b251f08f745a14d954) refactor - [`866b2cd`](https://github.com/Comfy-Org/desktop/commit/866b2cdeb8d67f050e34155a892c029f5a7aeb55) refactor ### 📊 Changes **1 file changed** (+189 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `tests/unit/install/installationManager.test.ts` (+189 -0) </details> ### 📄 Description This PR adds unit tests on installationManager `ensureInstalled` method, testing various installation validation scenarios. ![Selection_809](https://github.com/user-attachments/assets/67030b4c-78d8-438b-803e-ad265bbe213f) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-712-Test-Add-install-validation-unit-tests-1856d73d365081ed9d07eaedacf76a17) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:01 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:13 +00:00

[PR #1039] [MERGED] Update ComfyUI to v0.3.26 #1298

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1039

No description provided.

Rows
Columns