[PR #713] [MERGED] Add UV mirror settings #1040

New issue

Closed

opened 2026-10-31 22:19:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/713
Author: @huchenlei
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: mirror_settings

📝 Commits (1)

677f1ce Add UV mirror settings

📊 Changes

7 files changed (+52 additions, -11 deletions)

View changed files

📝 src/config/comfySettings.ts (+4 -0)
📝 src/install/installWizard.ts (+2 -0)
📝 src/main-process/comfyDesktopApp.ts (+4 -4)
📝 src/main-process/comfyInstallation.ts (+15 -3)
📝 src/preload.ts (+3 -0)
📝 src/virtualEnvironment.ts (+22 -4)
📝 tests/unit/comfySettings.test.ts (+2 -0)

📄 Description

Added new settings for Python and PyPI mirrors:
- Added PythonInstallMirror and PypiInstallMirror to DEFAULT_SETTINGS and ComfySettingsData interface
- These settings allow configuring alternative mirrors for Python and PyPI package installations
Refactored ComfyDesktopApp and ComfyInstallation:
- Moved ComfySettings management from ComfyDesktopApp to ComfyInstallation
- Changed ComfySettings to be a property in ComfyDesktopApp
Enhanced VirtualEnvironment:
- Refactored constructor to accept an options object instead of individual parameters
- Added support for Python and PyPI mirrors through environment variables
- Updated default Python version handling
Updated InstallWizard to include mirror settings in the installation options

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/713 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `mirror_settings` --- ### 📝 Commits (1) - [`677f1ce`](https://github.com/Comfy-Org/desktop/commit/677f1ceb4bb30de23b59ae6193fa964453b77e0a) Add UV mirror settings ### 📊 Changes **7 files changed** (+52 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfySettings.ts` (+4 -0) 📝 `src/install/installWizard.ts` (+2 -0) 📝 `src/main-process/comfyDesktopApp.ts` (+4 -4) 📝 `src/main-process/comfyInstallation.ts` (+15 -3) 📝 `src/preload.ts` (+3 -0) 📝 `src/virtualEnvironment.ts` (+22 -4) 📝 `tests/unit/comfySettings.test.ts` (+2 -0) </details> ### 📄 Description 1. Added new settings for Python and PyPI mirrors: - Added `PythonInstallMirror` and `PypiInstallMirror` to `DEFAULT_SETTINGS` and `ComfySettingsData` interface - These settings allow configuring alternative mirrors for Python and PyPI package installations 2. Refactored `ComfyDesktopApp` and `ComfyInstallation`: - Moved `ComfySettings` management from `ComfyDesktopApp` to `ComfyInstallation` - Changed `ComfySettings` to be a property in `ComfyDesktopApp` 3. Enhanced `VirtualEnvironment`: - Refactored constructor to accept an options object instead of individual parameters - Added support for Python and PyPI mirrors through environment variables - Updated default Python version handling 4. Updated `InstallWizard` to include mirror settings in the installation options ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-713-Add-UV-mirror-settings-1856d73d3650819d8968cff4212e18e5) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:01 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:15 +00:00

[PR #1040] [MERGED] Update Manager commit. #1300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1040

No description provided.

Rows
Columns