[PR #716] [MERGED] [Refactor] Remove unnecessary wrapper class on handlers #1043

New issue

Closed

opened 2026-10-31 22:19:02 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/716
Author: @huchenlei
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: de_class

📝 Commits (1)

88b6e7a [Refactor] Remove unnecessary wrapper class on handlers

📊 Changes

8 files changed (+141 additions, -169 deletions)

View changed files

📝 src/handlers/AppHandlers.ts (+5 -7)
📝 src/handlers/appInfoHandlers.ts (+38 -40)
📝 src/handlers/networkHandlers.ts (+7 -9)
📝 src/handlers/pathHandlers.ts (+75 -87)
📝 src/main.ts (+8 -8)
📝 tests/unit/handlers/AppHandlers.test.ts (+2 -5)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+3 -6)
📝 tests/unit/handlers/pathHandler.test.ts (+3 -7)

📄 Description

Remove unnecessary class wrappers.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/716 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `de_class` --- ### 📝 Commits (1) - [`88b6e7a`](https://github.com/Comfy-Org/desktop/commit/88b6e7ac43da782a9ca3989418bfce5a7240bf35) [Refactor] Remove unnecessary wrapper class on handlers ### 📊 Changes **8 files changed** (+141 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/AppHandlers.ts` (+5 -7) 📝 `src/handlers/appInfoHandlers.ts` (+38 -40) 📝 `src/handlers/networkHandlers.ts` (+7 -9) 📝 `src/handlers/pathHandlers.ts` (+75 -87) 📝 `src/main.ts` (+8 -8) 📝 `tests/unit/handlers/AppHandlers.test.ts` (+2 -5) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+3 -6) 📝 `tests/unit/handlers/pathHandler.test.ts` (+3 -7) </details> ### 📄 Description Remove unnecessary class wrappers. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-716-Refactor-Remove-unnecessary-wrapper-class-on-handlers-1856d73d365081d999dbd36c8fdcb254) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:02 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:15 +00:00

[PR #1043] [MERGED] [CI] Fix regression - all command output discarded #1302

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1043

No description provided.

Rows
Columns