[PR #721] [CLOSED] [Test] Add e2e test on beforeunload bug #1045

New issue

Closed

opened 2026-10-31 22:19:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/721
Author: @christian-byrne
Created: 1/24/2025
Status: ❌ Closed

Base: main ← Head: test/beforeunload-confirm

📝 Commits (2)

d5b7192 add test on beforeunload bug
1cc21ab force ordering of tests

📊 Changes

6 files changed (+76 additions, -15 deletions)

View changed files

📝 tests/integration/001-installApp.spec.ts (+0 -0)
📝 tests/integration/002-installWizard.spec.ts (+0 -0)
➕ tests/integration/003-appWindow.spec.ts (+33 -0)
➖ tests/integration/appWindow.spec.ts (+0 -15)
📝 tests/integration/testInstallWizard.ts (+17 -0)
📝 tests/integration/testInstalledApp.ts (+26 -0)

📄 Description

This PR adds a test on the issue fixed in https://github.com/Comfy-Org/ComfyUI_frontend/pull/2318 by creating an unsaved workflow and then closing the page with runBeforeUnload option enabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/721 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/beforeunload-confirm` --- ### 📝 Commits (2) - [`d5b7192`](https://github.com/Comfy-Org/desktop/commit/d5b719242eac93ae4ba79c14149ccf5c1c3b4936) add test on beforeunload bug - [`1cc21ab`](https://github.com/Comfy-Org/desktop/commit/1cc21ab95e95a4f49aae3c80844bfa1ba75e544c) force ordering of tests ### 📊 Changes **6 files changed** (+76 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/001-installApp.spec.ts` (+0 -0) 📝 `tests/integration/002-installWizard.spec.ts` (+0 -0) ➕ `tests/integration/003-appWindow.spec.ts` (+33 -0) ➖ `tests/integration/appWindow.spec.ts` (+0 -15) 📝 `tests/integration/testInstallWizard.ts` (+17 -0) 📝 `tests/integration/testInstalledApp.ts` (+26 -0) </details> ### 📄 Description This PR adds a test on the issue fixed in https://github.com/Comfy-Org/ComfyUI_frontend/pull/2318 by creating an unsaved workflow and then closing the page with `runBeforeUnload` option enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:04 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1045

No description provided.

Rows
Columns