[PR #727] [MERGED] [Refactor] Rename AppWindow loadRenderer to loadPage #1050

New issue

Closed

opened 2026-10-31 22:19:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/727
Author: @webfiltered
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @webfiltered

Base: main ← Head: clarify-app-window

📝 Commits (5)

73640a5 nit - Doc
c9a57ab [Refactor] Rename for clarity - AppWindow.loadPage
9dad754 Add TS type
3d8fefa nit - Rename for clarity
d030e35 Fix tests

📊 Changes

8 files changed (+35 additions, -26 deletions)

View changed files

📝 src/install/installationManager.ts (+3 -3)
📝 src/main-process/appWindow.ts (+12 -3)
📝 src/main-process/comfyDesktopApp.ts (+1 -1)
📝 src/main.ts (+1 -1)
📝 src/services/telemetry.ts (+1 -1)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+3 -3)
📝 tests/unit/install/installationManager.test.ts (+3 -3)
📝 tests/unit/telemetry.test.ts (+11 -11)

📄 Description

Renames loadRenderer to loadPage
Adds TS type to allow auto-complete of valid pages

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/727 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `clarify-app-window` --- ### 📝 Commits (5) - [`73640a5`](https://github.com/Comfy-Org/desktop/commit/73640a54590a4917b841c4f5203d9581e5a84166) nit - Doc - [`c9a57ab`](https://github.com/Comfy-Org/desktop/commit/c9a57ab90eb3e828cd989c5b98595c27ae127f30) [Refactor] Rename for clarity - AppWindow.loadPage - [`9dad754`](https://github.com/Comfy-Org/desktop/commit/9dad754a469bba1549240ef52278ae3a56b513cf) Add TS type - [`3d8fefa`](https://github.com/Comfy-Org/desktop/commit/3d8fefa1792a5c6d0802241ce06f6139132215f9) nit - Rename for clarity - [`d030e35`](https://github.com/Comfy-Org/desktop/commit/d030e35df5b7156bb801fbe61a0a4df0e7f75f7a) Fix tests ### 📊 Changes **8 files changed** (+35 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+3 -3) 📝 `src/main-process/appWindow.ts` (+12 -3) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -1) 📝 `src/main.ts` (+1 -1) 📝 `src/services/telemetry.ts` (+1 -1) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+3 -3) 📝 `tests/unit/install/installationManager.test.ts` (+3 -3) 📝 `tests/unit/telemetry.test.ts` (+11 -11) </details> ### 📄 Description - Renames `loadRenderer` to `loadPage` - Adds TS type to allow auto-complete of valid pages ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-727-Refactor-Rename-AppWindow-loadRenderer-to-loadPage-1856d73d365081a09917efb917f37276) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:17 +00:00

[PR #1050] [MERGED] v0.4.30 #1306

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1050

No description provided.

Rows
Columns