[PR #730] [MERGED] Allow app to check the current browser location #1053

New issue

Closed

opened 2026-10-31 22:19:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/730
Author: @webfiltered
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @huchenlei

Base: main ← Head: current-page-check

📝 Commits (1)

667eea6 Add current page check to AppWindow

📊 Changes

1 file changed (+16 additions, -1 deletions)

View changed files

📝 src/main-process/appWindow.ts (+16 -1)

📄 Description

Current

Classes in the app have no way to determine what page the browser is currently showing
If we want to ensure we're on a specific page, we need to force navigate to the URL (awful UX, usually resets something)

Proposed

A type-safe check to determine if a page is already the current window URL

Alternative

Save the last requested page: frontend uses redirects, rendering this inaccurate

N.B. Split from larger PR on venv move.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/730 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `current-page-check` --- ### 📝 Commits (1) - [`667eea6`](https://github.com/Comfy-Org/desktop/commit/667eea66c39c8a0a20673f4f798b114452eab58a) Add current page check to AppWindow ### 📊 Changes **1 file changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+16 -1) </details> ### 📄 Description #### Current - Classes in the app have no way to determine what page the browser is currently showing - If we want to ensure we're on a specific page, we need to force navigate to the URL (awful UX, usually resets something) #### Proposed - A type-safe check to determine if a page is already the current window URL #### Alternative - Save the last requested page: frontend uses redirects, rendering this inaccurate N.B. Split from larger PR on venv move. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-730-Allow-app-to-check-the-current-browser-location-1856d73d3650813c9cdeec66eb4661f0) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:07 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1053

No description provided.

Rows
Columns