[PR #735] [MERGED] Fix error in #730 - isOnPage crashes #1057

New issue

Closed

opened 2026-10-31 22:19:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/735
Author: @webfiltered
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @webfiltered

Base: main ← Head: fix-730

📝 Commits (2)

35a46b8 Fix node syntax error (type mismatch)
1740190 Add tests

📊 Changes

2 files changed (+116 additions, -1 deletions)

View changed files

📝 src/main-process/appWindow.ts (+1 -1)
➕ tests/unit/main-process/appWindow.test.ts (+115 -0)

📄 Description

TS type libs do not match runtime
Convert static URL.parse to new URL
Adds unit tests

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/735 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-730` --- ### 📝 Commits (2) - [`35a46b8`](https://github.com/Comfy-Org/desktop/commit/35a46b884717e86fc237c891d2bf87b9fd427b3d) Fix node syntax error (type mismatch) - [`1740190`](https://github.com/Comfy-Org/desktop/commit/1740190584521c6fc29a5b0c7cd5ffdb22a5528b) Add tests ### 📊 Changes **2 files changed** (+116 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+1 -1) ➕ `tests/unit/main-process/appWindow.test.ts` (+115 -0) </details> ### 📄 Description - TS type libs do not match runtime - Convert static `URL.parse` to `new URL` - Adds unit tests ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-735-Fix-error-in-730-isOnPage-crashes-1856d73d365081379c2bcde470831337) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:09 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1057

No description provided.

Rows
Columns