[PR #749] [MERGED] [Test] Fix installationManager test on Windows #1066

New issue

Closed

opened 2026-10-31 22:19:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/749
Author: @webfiltered
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @webfiltered

Base: main ← Head: win32-test-installation-manager

📝 Commits (2)

b7e1212 Remove unused code.
d9412b1 [Test] Fix installationManager test on Windows

📊 Changes

1 file changed (+2 additions, -13 deletions)

View changed files

📝 tests/unit/install/installationManager.test.ts (+2 -13)

📄 Description

Automatically bypasses the VC++ redist test in Windows unit tests.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/749 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `win32-test-installation-manager` --- ### 📝 Commits (2) - [`b7e1212`](https://github.com/Comfy-Org/desktop/commit/b7e1212afaf08d3b562ad04b43800e177a0ffec5) Remove unused code. - [`d9412b1`](https://github.com/Comfy-Org/desktop/commit/d9412b1e7c509748b43395d42feaaffc7ece229a) [Test] Fix installationManager test on Windows ### 📊 Changes **1 file changed** (+2 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/install/installationManager.test.ts` (+2 -13) </details> ### 📄 Description Automatically bypasses the VC++ redist test in Windows unit tests. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-749-Test-Fix-installationManager-test-on-Windows-1896d73d365081149887ca691b6f4849) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:13 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:22 +00:00

[PR #1066] [MERGED] Check response of shell.openPath for errors. #1315

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1066

No description provided.

Rows
Columns