[PR #756] [MERGED] [CodeHealth] Access modifiers and nits #1073

New issue

Closed

opened 2026-10-31 22:19:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/756
Author: @webfiltered
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @webfiltered

Base: main ← Head: nits

📝 Commits (3)

4e73f14 nit
e88f679 nit - Remove export from internal functions
aacd541 nit - Prefer TS interface over type

📊 Changes

2 files changed (+7 additions, -8 deletions)

View changed files

📝 src/main-process/comfyDesktopApp.ts (+3 -4)
📝 src/virtualEnvironment.ts (+4 -4)

📄 Description

No functional changes.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/756 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `nits` --- ### 📝 Commits (3) - [`4e73f14`](https://github.com/Comfy-Org/desktop/commit/4e73f14c20411d0fec3e9854ca295ea7992b973e) nit - [`e88f679`](https://github.com/Comfy-Org/desktop/commit/e88f679569edabc1a9d5aa8a457a115674c72413) nit - Remove export from internal functions - [`aacd541`](https://github.com/Comfy-Org/desktop/commit/aacd5411595de895e2617f004760037ef77275ae) nit - Prefer TS interface over type ### 📊 Changes **2 files changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/comfyDesktopApp.ts` (+3 -4) 📝 `src/virtualEnvironment.ts` (+4 -4) </details> ### 📄 Description No functional changes. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-756-CodeHealth-Access-modifiers-and-nits-1896d73d3650816ab8f5e298c8c5cc05) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:16 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:25 +00:00

[PR #1073] [MERGED] Update patch to update requirements. #1321

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1073

No description provided.

Rows
Columns