[PR #775] [MERGED] [Reland] Fix misaligned mirror setting ids #1091

Closed
opened 2026-10-31 22:19:24 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/775
Author: @huchenlei
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @huchenlei

Base: main ← Head: fix_setting_ids


📝 Commits (2)

  • f2af5b8 Fix misaligned setting ids for UV mirrors (#773)
  • fc3bea3 [Reland] Fix misaligned mirror setting ids

📊 Changes

4 files changed (+15 additions, -15 deletions)

View changed files

📝 src/config/comfySettings.ts (+6 -6)
📝 src/install/installWizard.ts (+3 -3)
📝 src/main-process/comfyInstallation.ts (+3 -3)
📝 tests/unit/comfySettings.test.ts (+3 -3)

📄 Description

Reland #773

┆Issue is synchronized with this Notion page by Unito


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/775 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_setting_ids` --- ### 📝 Commits (2) - [`f2af5b8`](https://github.com/Comfy-Org/desktop/commit/f2af5b8294c15a71687232a296002cff40cefd24) Fix misaligned setting ids for UV mirrors (#773) - [`fc3bea3`](https://github.com/Comfy-Org/desktop/commit/fc3bea350a464cba8cedec4b0afeb5f636144054) [Reland] Fix misaligned mirror setting ids ### 📊 Changes **4 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfySettings.ts` (+6 -6) 📝 `src/install/installWizard.ts` (+3 -3) 📝 `src/main-process/comfyInstallation.ts` (+3 -3) 📝 `tests/unit/comfySettings.test.ts` (+3 -3) </details> ### 📄 Description Reland #773 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-775-Reland-Fix-misaligned-mirror-setting-ids-18a6d73d3650812ab7d0cd813f40c269) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:19:24 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#1091
No description provided.