[PR #783] [MERGED] Disable unicorn optimisation rule #1094

New issue

Closed

opened 2026-10-31 22:19:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/783
Author: @webfiltered
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @webfiltered

Base: main ← Head: disable-unicorn-optimisation

📝 Commits (1)

c3217cf Disable unicorn optimisation rule

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 eslint.config.js (+1 -0)

📄 Description

This rule is currently counterproductive for this repo. It provides no detectable performance gain, but requires distancing even minute functions from the calling code.

Prefer maintainability in this instance.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/783 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `disable-unicorn-optimisation` --- ### 📝 Commits (1) - [`c3217cf`](https://github.com/Comfy-Org/desktop/commit/c3217cfe4b97e1ebb5b91eee52d0b6bb053f722d) Disable unicorn optimisation rule ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.js` (+1 -0) </details> ### 📄 Description This rule is currently counterproductive for this repo. It provides no detectable performance gain, but requires distancing even minute functions from the calling code. Prefer maintainability in this instance. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-783-Disable-unicorn-optimisation-rule-18b6d73d36508124b255fd0efcae5332) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:26 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1094

No description provided.

Rows
Columns