[PR #784] [MERGED] [Refactor] Simplify code - use desktop config for device #1097

New issue

Closed

opened 2026-10-31 22:19:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/784
Author: @webfiltered
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @webfiltered

Base: main ← Head: remove-device-pass

📝 Commits (1)

01ade7c Simplify code - use desktop config for device

📊 Changes

2 files changed (+5 additions, -13 deletions)

View changed files

📝 src/install/installationManager.ts (+1 -7)
📝 src/main-process/comfyInstallation.ts (+4 -6)

📄 Description

Removes unnecessary passing of the selected torch device; reads from settings when required.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/784 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `remove-device-pass` --- ### 📝 Commits (1) - [`01ade7c`](https://github.com/Comfy-Org/desktop/commit/01ade7c4e97b4f042d11db15b57697fd1739f477) Simplify code - use desktop config for device ### 📊 Changes **2 files changed** (+5 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+1 -7) 📝 `src/main-process/comfyInstallation.ts` (+4 -6) </details> ### 📄 Description Removes unnecessary passing of the selected torch device; reads from settings when required. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-784-Refactor-Simplify-code-use-desktop-config-for-device-18b6d73d365081299611edbcb78cbcab) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:26 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:32 +00:00

[PR #1097] [MERGED] Add electron update and restart IPC events #1335

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1097

No description provided.

Rows
Columns