[PR #786] [MERGED] Add TS types - telemetry trackEvent #1101

New issue

Closed

opened 2026-10-31 22:19:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/786
Author: @webfiltered
Created: 1/30/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: fix-ts-types

📝 Commits (2)

7553a6a nit - Remove unused eslint suppression
12d0b6e Add TS types - telemetry trackEvent

📊 Changes

2 files changed (+21 additions, -28 deletions)

View changed files

📝 src/main-process/appWindow.ts (+0 -1)
📝 src/services/telemetry.ts (+21 -27)

📄 Description

Adds TS types to trackEvent.
Removes unused ESLint suppression

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/786 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-ts-types` --- ### 📝 Commits (2) - [`7553a6a`](https://github.com/Comfy-Org/desktop/commit/7553a6a814473bcbe51af1430085f82c8ec859dd) nit - Remove unused eslint suppression - [`12d0b6e`](https://github.com/Comfy-Org/desktop/commit/12d0b6edf5e9126b0d4dd47191a1dad93f6d88b2) Add TS types - telemetry trackEvent ### 📊 Changes **2 files changed** (+21 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+0 -1) 📝 `src/services/telemetry.ts` (+21 -27) </details> ### 📄 Description - Adds TS types to `trackEvent`. - Removes unused ESLint suppression ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-786-Add-TS-types-telemetry-trackEvent-18b6d73d365081cea8a1f20357c06f2b) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:28 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:33 +00:00

[PR #1101] [MERGED] [API] Publish types for version 0.4.37 #1338

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1101

No description provided.

Rows
Columns