[PR #804] [MERGED] Fixed: missing mock for unit test on MacOS. #1116

New issue

Closed

opened 2026-10-31 22:19:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/804
Author: @robinjhuang
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @robinjhuang

Base: main ← Head: rh-mactest

📝 Commits (3)

f81fded Add mock that only used in MacOS.
8f14acb Make sure CI runs on macos and windows.
9cef418 Add eol for different OS.

📊 Changes

3 files changed (+6 additions, -1 deletions)

View changed files

📝 .gitattributes (+1 -0)
📝 .github/workflows/ci.yaml (+4 -1)
📝 tests/unit/main-process/appWindow.test.ts (+1 -0)

📄 Description

Was missing a mock for a function that was only hit on macos.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/804 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-mactest` --- ### 📝 Commits (3) - [`f81fded`](https://github.com/Comfy-Org/desktop/commit/f81fded8ff7af9eeadd8b0c8c8bb10f636897ca3) Add mock that only used in MacOS. - [`8f14acb`](https://github.com/Comfy-Org/desktop/commit/8f14acbcca7af64606e91cbcb9a61a1c2a6905cd) Make sure CI runs on macos and windows. - [`9cef418`](https://github.com/Comfy-Org/desktop/commit/9cef418d1f7e60f9c8caaa3eeef3e818c4b437bf) Add eol for different OS. ### 📊 Changes **3 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.gitattributes` (+1 -0) 📝 `.github/workflows/ci.yaml` (+4 -1) 📝 `tests/unit/main-process/appWindow.test.ts` (+1 -0) </details> ### 📄 Description Was missing a mock for a function that was only hit on macos. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-804-Fixed-missing-mock-for-unit-test-on-MacOS-18f6d73d365081cfb28ae13774c2c82a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:37 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:38 +00:00

[PR #1116] [MERGED] Add API node support & frontend 1.17.9 #1347

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1116

No description provided.

Rows
Columns