[PR #807] [MERGED] Update restart app API to use invoke/handle #1117

New issue

Closed

opened 2026-10-31 22:19:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/807
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: separate-restart-app

📝 Commits (7)

a75cf9a nit - Remove redundant code
7d87ebc Simplify log messages
85e8b7a [Refactor] Move restart app handler to AppHandlers
bf3fd48 [Refactor] Prefer async/await
425c89a Remove unhandled exception swallowing
f6376e6 Remove redundant code
3ad1a76 Update restartApp API method - async/await

📊 Changes

3 files changed (+46 additions, -59 deletions)

View changed files

📝 src/handlers/AppHandlers.ts (+43 -1)
📝 src/main-process/comfyDesktopApp.ts (+1 -56)
📝 src/preload.ts (+2 -2)

📄 Description

Separates app restart code to IPC handler
Replaces old on/off with awaitable invoke/handle

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/807 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `separate-restart-app` --- ### 📝 Commits (7) - [`a75cf9a`](https://github.com/Comfy-Org/desktop/commit/a75cf9ad5b192dd32d356a62868ae3f305e74af7) nit - Remove redundant code - [`7d87ebc`](https://github.com/Comfy-Org/desktop/commit/7d87ebc2934a227f89205026ba42847d81639ed4) Simplify log messages - [`85e8b7a`](https://github.com/Comfy-Org/desktop/commit/85e8b7ac25aaa75add69706051d5bfa4b07a3950) [Refactor] Move restart app handler to AppHandlers - [`bf3fd48`](https://github.com/Comfy-Org/desktop/commit/bf3fd48bf04ed584fcfe34a5c6dbb38215b5da61) [Refactor] Prefer async/await - [`425c89a`](https://github.com/Comfy-Org/desktop/commit/425c89a3c3b666aa5cb28ce36644d17a524eae6f) Remove unhandled exception swallowing - [`f6376e6`](https://github.com/Comfy-Org/desktop/commit/f6376e6d4ffed9ea183137f3c6b490bba38256e3) Remove redundant code - [`3ad1a76`](https://github.com/Comfy-Org/desktop/commit/3ad1a7636c7d07921cf5aa9a2c9fc28e2ab813d2) Update restartApp API method - async/await ### 📊 Changes **3 files changed** (+46 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/AppHandlers.ts` (+43 -1) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -56) 📝 `src/preload.ts` (+2 -2) </details> ### 📄 Description - Separates app restart code to IPC handler - Replaces old on/off with awaitable invoke/handle ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-807-Separate-restart-app-1906d73d36508111a644f11e74b20081) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:38 +00:00

[PR #1117] [MERGED] v0.4.40 #1344

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1117

No description provided.

Rows
Columns