[PR #806] [MERGED] Improve startup error handling & clean up #1118

New issue

Closed

opened 2026-10-31 22:19:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/806
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: clean-main-vi

📝 Commits (5)

9475ac3 nit
ab48e9a [Refactor] Simplify code - app window to initializer
4a66008 [Refactor] Declarative - show loading page
3332c14 [Refactor] Declarative code split
b00d090 Improve error handling

📊 Changes

2 files changed (+35 additions, -23 deletions)

View changed files

📝 src/desktopApp.ts (+34 -23)
📝 src/main.ts (+1 -0)

📄 Description

Improves unexpected error handling
Simplifies code
Part of larger refactor

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/806 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `clean-main-vi` --- ### 📝 Commits (5) - [`9475ac3`](https://github.com/Comfy-Org/desktop/commit/9475ac344af3912546544f60cfc1812c83c1f56f) nit - [`ab48e9a`](https://github.com/Comfy-Org/desktop/commit/ab48e9ab0ffd303a08add3f6243cb595dafc87c2) [Refactor] Simplify code - app window to initializer - [`4a66008`](https://github.com/Comfy-Org/desktop/commit/4a660084ca919b9a349f78b6ebad3acd56ff19e0) [Refactor] Declarative - show loading page - [`3332c14`](https://github.com/Comfy-Org/desktop/commit/3332c14dc8cd98fd7e2502c22b4b75436051a3d0) [Refactor] Declarative code split - [`b00d090`](https://github.com/Comfy-Org/desktop/commit/b00d090619b3a9b3ae05187be11540f82eb30196) Improve error handling ### 📊 Changes **2 files changed** (+35 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/desktopApp.ts` (+34 -23) 📝 `src/main.ts` (+1 -0) </details> ### 📄 Description - Improves unexpected error handling - Simplifies code - Part of larger refactor ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-806-Improve-startup-error-handling-clean-up-1906d73d365081ee812ef8549691f41c) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:38 +00:00

[PR #1118] [MERGED] Update compiled packages to match core reqs #1345

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1118

No description provided.

Rows
Columns