[PR #813] [MERGED] [Refactor] Move app reinstallation (SoC) #1125

New issue

Closed

opened 2026-10-31 22:19:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/813
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: move-reinstall

📝 Commits (1)

ffddc8f [Refactor] Move app reinstallation (SoC)

📊 Changes

2 files changed (+9 additions, -13 deletions)

View changed files

📝 src/install/installationManager.ts (+9 -6)
📝 src/main-process/comfyDesktopApp.ts (+0 -7)

📄 Description

Moves app reinstall to InstallationManager.
Ensures reinstall always references the correct install.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/813 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `move-reinstall` --- ### 📝 Commits (1) - [`ffddc8f`](https://github.com/Comfy-Org/desktop/commit/ffddc8f11b4e0fa738f88858f8019c39b032db3a) [Refactor] Move app reinstallation (SoC) ### 📊 Changes **2 files changed** (+9 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+9 -6) 📝 `src/main-process/comfyDesktopApp.ts` (+0 -7) </details> ### 📄 Description - Moves app reinstall to InstallationManager. - Ensures reinstall always references the correct install. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-813-Refactor-Move-app-reinstallation-SoC-1906d73d365081e8910ed604915187fe) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:43 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:42 +00:00

[PR #1125] [MERGED] [Test] Temporarily increase test duration #1354

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1125

No description provided.

Rows
Columns