[PR #819] [MERGED] Force app quit only when still on the start page #1128

New issue

Closed

opened 2026-10-31 22:19:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/819
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: install-errror-recovery

📝 Commits (3)

2b18ce1 Prevent app quit on installation failure
774abbb Force app quit only when still on the start page
9ee9914 Update tests

📊 Changes

5 files changed (+47 additions, -13 deletions)

View changed files

📝 src/desktopApp.ts (+26 -8)
📝 src/infrastructure/interfaces.ts (+10 -0)
📝 src/main-process/appState.ts (+5 -0)
📝 src/main-process/appWindow.ts (+5 -4)
📝 tests/unit/main-process/appWindow.test.ts (+1 -1)

📄 Description

Workaround (not a resolution) for #818
Prevents unwanted native OS error message + force quit install errors during virtual environment creation

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/819 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `install-errror-recovery` --- ### 📝 Commits (3) - [`2b18ce1`](https://github.com/Comfy-Org/desktop/commit/2b18ce17df84700bde595ba7b62aadb93fc7e1c3) Prevent app quit on installation failure - [`774abbb`](https://github.com/Comfy-Org/desktop/commit/774abbbfdc98b381a1ba06ebff11300f6837351e) Force app quit only when still on the start page - [`9ee9914`](https://github.com/Comfy-Org/desktop/commit/9ee9914d6e524adda7f71ba75a55e0cbc93d064f) Update tests ### 📊 Changes **5 files changed** (+47 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/desktopApp.ts` (+26 -8) 📝 `src/infrastructure/interfaces.ts` (+10 -0) 📝 `src/main-process/appState.ts` (+5 -0) 📝 `src/main-process/appWindow.ts` (+5 -4) 📝 `tests/unit/main-process/appWindow.test.ts` (+1 -1) </details> ### 📄 Description - Workaround (not a resolution) for #818 - Prevents unwanted native OS error message + force quit install errors during virtual environment creation ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-819-Force-app-quit-only-when-still-on-the-start-page-1906d73d36508171a91ef83f37ec883e) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:43 +00:00