[PR #822] [MERGED] [Refactor] Declarative code split - server args #1131

New issue

Closed

opened 2026-10-31 22:19:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/822
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: clean-main-xi

📝 Commits (3)

1c48305 Initialize telemetry earlier
8f41e7d nit
17a7937 [Refactor] Declarative code split - server args

📊 Changes

3 files changed (+30 additions, -23 deletions)

View changed files

📝 src/desktopApp.ts (+8 -21)
📝 src/main-process/comfyDesktopApp.ts (+18 -2)
📝 src/main-process/devOverrides.ts (+4 -0)

📄 Description

Part of larger app startup refactor
Moves server arg instantiation to more logical location (same class that starts/stops the server)
Initializes telemetry earlier, as there is no longer a reliance on ComfyDesktopApp

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/822 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `clean-main-xi` --- ### 📝 Commits (3) - [`1c48305`](https://github.com/Comfy-Org/desktop/commit/1c48305f5dd87d002f6c3a4305e573544bd5187c) Initialize telemetry earlier - [`8f41e7d`](https://github.com/Comfy-Org/desktop/commit/8f41e7dd53a3947b16491869b82212ea8692d25d) nit - [`17a7937`](https://github.com/Comfy-Org/desktop/commit/17a7937d1aafcd49d2661c6be636774038e8a4a9) [Refactor] Declarative code split - server args ### 📊 Changes **3 files changed** (+30 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/desktopApp.ts` (+8 -21) 📝 `src/main-process/comfyDesktopApp.ts` (+18 -2) 📝 `src/main-process/devOverrides.ts` (+4 -0) </details> ### 📄 Description - Part of larger app startup refactor - Moves server arg instantiation to more logical location (same class that starts/stops the server) - Initializes telemetry earlier, as there is no longer a reliance on ComfyDesktopApp ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-822-Refactor-Declarative-code-split-server-args-1906d73d365081ec8ec4e521e60761a9) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:46 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1131

No description provided.

Rows
Columns