[PR #823] [MERGED] [Refactor] Remove server argument workarounds #1132

New issue

Closed

opened 2026-10-31 22:19:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/823
Author: @webfiltered
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @webfiltered

Base: main ← Head: simplify-server-args

📝 Commits (1)

e698d35 [Refactor] Remove server argument workarounds

📊 Changes

4 files changed (+35 additions, -22 deletions)

View changed files

📝 src/constants.ts (+9 -7)
📝 src/main-process/appWindow.ts (+1 -1)
📝 src/main-process/comfyDesktopApp.ts (+23 -10)
📝 src/main-process/comfyServer.ts (+2 -4)

📄 Description

Removes workarounds that were layered on top of each other (no longer relevant or required).
Args are now a single POJO.
Renames host to listen; this is the name of the ComfyUI server argument. Can be changed to host again and a simple translation function implemented at the server start, if required.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/823 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `simplify-server-args` --- ### 📝 Commits (1) - [`e698d35`](https://github.com/Comfy-Org/desktop/commit/e698d35e6f1c98281827ca3d4514da94c43c5220) [Refactor] Remove server argument workarounds ### 📊 Changes **4 files changed** (+35 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+9 -7) 📝 `src/main-process/appWindow.ts` (+1 -1) 📝 `src/main-process/comfyDesktopApp.ts` (+23 -10) 📝 `src/main-process/comfyServer.ts` (+2 -4) </details> ### 📄 Description - Removes workarounds that were layered on top of each other (no longer relevant or required). - Args are now a single POJO. - Renames `host` to `listen`; this is the name of the ComfyUI server argument. Can be changed to host again and a simple translation function implemented at the server start, if required. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-823-Refactor-Remove-server-argument-workarounds-1906d73d36508155927cdd917f3c21a5) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:46 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:45 +00:00

[PR #1132] [MERGED] Update README.md #1361

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1132

No description provided.

Rows
Columns