[PR #828] [MERGED] Use global uv cache. #1135

New issue

Closed

opened 2026-10-31 22:19:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/828
Author: @robinjhuang
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @robinjhuang

Base: main ← Head: rh-uvcache

📝 Commits (1)

1d23f4b Use global uv cache.

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 src/virtualEnvironment.ts (+0 -4)

📄 Description

Remove the local cache.

Benefit from the global uv cache for all users of uv (eg. torch doesn't need to be downloaded again)
Avoid issues where cache is not compatible on an external hard drive (eg. drives with exFat formatting)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/828 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-uvcache` --- ### 📝 Commits (1) - [`1d23f4b`](https://github.com/Comfy-Org/desktop/commit/1d23f4bc1518572bbc9409c6cfc5aabcf3ef2592) Use global uv cache. ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+0 -4) </details> ### 📄 Description Remove the local cache. - Benefit from the global uv cache for all users of uv (eg. torch doesn't need to be downloaded again) - Avoid issues where cache is not compatible on an external hard drive (eg. drives with exFat formatting) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-828-Use-global-uv-cache-1916d73d365081648813edd818f8951a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:48 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:45 +00:00

[PR #1135] [MERGED] [nit] Use structured logging #1362

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1135

No description provided.

Rows
Columns