[PR #827] [MERGED] [Types] Add weak abstraction interface for ComfySettings #1136

New issue

Closed

opened 2026-10-31 22:19:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/827
Author: @webfiltered
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @webfiltered

Base: main ← Head: add-settings-interface

📝 Commits (4)

7f71a74 Add missing interface members
5ea70f8 Add weak abstraction interface for ComfySettings
362c013 Use ComfySettings interface
de788be [Test] Update settings test

📊 Changes

3 files changed (+49 additions, -7 deletions)

View changed files

📝 src/config/comfySettings.ts (+43 -5)
📝 src/services/telemetry.ts (+2 -2)
📝 tests/unit/comfySettings.test.ts (+4 -0)

📄 Description

Adds TS types
Docs

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/827 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `add-settings-interface` --- ### 📝 Commits (4) - [`7f71a74`](https://github.com/Comfy-Org/desktop/commit/7f71a7418d4ee5fb821a7674ae6efb8f317b6d83) Add missing interface members - [`5ea70f8`](https://github.com/Comfy-Org/desktop/commit/5ea70f8554731c9696316321ffdacdb8dba95cc7) Add weak abstraction interface for ComfySettings - [`362c013`](https://github.com/Comfy-Org/desktop/commit/362c013964f42a49fa6ad7f2036c3ffe0254e09b) Use ComfySettings interface - [`de788be`](https://github.com/Comfy-Org/desktop/commit/de788be0c7081d1db2710d89baeeeaa57e710002) [Test] Update settings test ### 📊 Changes **3 files changed** (+49 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfySettings.ts` (+43 -5) 📝 `src/services/telemetry.ts` (+2 -2) 📝 `tests/unit/comfySettings.test.ts` (+4 -0) </details> ### 📄 Description - Adds TS types - Docs ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-827-Types-Add-weak-abstraction-interface-for-ComfySettings-1916d73d365081948fa8e1ee585b88d3) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:48 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1136

No description provided.

Rows
Columns