[PR #829] [MERGED] Add tracking for python mirror urls. #1137

New issue

Closed

opened 2026-10-31 22:19:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/829
Author: @robinjhuang
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @robinjhuang

Base: main ← Head: rh-mirrortelemetry

📝 Commits (2)

c2d70ca Add tracking for mirror urls.
b5c82c7 Fix tests.

📊 Changes

3 files changed (+24 additions, -7 deletions)

View changed files

📝 src/install/installationManager.ts (+4 -0)
📝 src/services/telemetry.ts (+1 -1)
📝 tests/unit/telemetry.test.ts (+19 -6)

📄 Description

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/829 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-mirrortelemetry` --- ### 📝 Commits (2) - [`c2d70ca`](https://github.com/Comfy-Org/desktop/commit/c2d70ca2142b25a7dfe5a2515e65fc09dd5be3a5) Add tracking for mirror urls. - [`b5c82c7`](https://github.com/Comfy-Org/desktop/commit/b5c82c77fd6ea9d942a54dd9846a24de7967d04c) Fix tests. ### 📊 Changes **3 files changed** (+24 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+4 -0) 📝 `src/services/telemetry.ts` (+1 -1) 📝 `tests/unit/telemetry.test.ts` (+19 -6) </details> ### 📄 Description ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-829-Add-tracking-for-python-mirror-urls-1916d73d36508132b40fc9e62b1adb5e) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:48 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1137

No description provided.

Rows
Columns