[PR #838] [MERGED] Empty telemetry from front of the queue. #1139

New issue

Closed

opened 2026-10-31 22:19:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/838
Author: @robinjhuang
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @robinjhuang

Base: main ← Head: rh-dependecies

📝 Commits (3)

e93ca98 Empty telemetry from the front of the queue.
b7987a3 Fix, send miliseconds since epoch.
81f85c5 Fix tests.

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 src/services/telemetry.ts (+2 -2)
📝 tests/unit/telemetry.test.ts (+2 -2)

📄 Description

Previously was FIFO and that was a bug...

Fix sending correct timestamp.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/838 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-dependecies` --- ### 📝 Commits (3) - [`e93ca98`](https://github.com/Comfy-Org/desktop/commit/e93ca989647d4f0d441415368dcab8ec9672d189) Empty telemetry from the front of the queue. - [`b7987a3`](https://github.com/Comfy-Org/desktop/commit/b7987a31b0090dd0c26bd48b076d47cea452665a) Fix, send miliseconds since epoch. - [`81f85c5`](https://github.com/Comfy-Org/desktop/commit/81f85c5ae630d601afec86030e2bfbafbd5aac78) Fix tests. ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/services/telemetry.ts` (+2 -2) 📝 `tests/unit/telemetry.test.ts` (+2 -2) </details> ### 📄 Description Previously was FIFO and that was a bug... - Fix sending correct timestamp. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-838-Empty-telemetry-from-front-of-the-queue-1926d73d3650810ea658d17452fb87ea) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:50 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:47 +00:00

[PR #1139] [MERGED] v0.4.44 #1365

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1139

No description provided.

Rows
Columns