[PR #841] [MERGED] Add manager package checks #1143

New issue

Closed

opened 2026-10-31 22:19:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/841
Author: @webfiltered
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @webfiltered

Base: main ← Head: vevn-manager-packages

📝 Commits (5)

212df9d Allow parsing uv requirements output
3a16ff0 Add manager python packages validation task
cd9d7dd Detect manager update packages missing
9219614 Automatically install updated manager requirements
e3704d0 Add terminal output of manager package update

📊 Changes

5 files changed (+51 additions, -9 deletions)

View changed files

📝 src/infrastructure/interfaces.ts (+2 -1)
📝 src/install/installationManager.ts (+18 -0)
📝 src/main-process/comfyInstallation.ts (+8 -2)
📝 src/preload.ts (+1 -0)
📝 src/virtualEnvironment.ts (+22 -6)

📄 Description

Requires https://github.com/Comfy-Org/ComfyUI_frontend/pull/2454
Adds ability to parse uv output when detecting installed python packages
Adds check for the manager package update (toml, uv)
Adds validation entry managerPythonPackages - reports warning
Notifies user by loading new desktop-update route
Resolves #834

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/841 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `vevn-manager-packages` --- ### 📝 Commits (5) - [`212df9d`](https://github.com/Comfy-Org/desktop/commit/212df9d2c9cad21ff7ec8a6b56e31efb7cf6e549) Allow parsing uv requirements output - [`3a16ff0`](https://github.com/Comfy-Org/desktop/commit/3a16ff01d3e52450001813364e33eccea735ba2f) Add manager python packages validation task - [`cd9d7dd`](https://github.com/Comfy-Org/desktop/commit/cd9d7dd60d459494e92ee0ab8c5ea42a89db703a) Detect manager update packages missing - [`9219614`](https://github.com/Comfy-Org/desktop/commit/9219614520f9855c9540b12ec9d061d0a61b2871) Automatically install updated manager requirements - [`e3704d0`](https://github.com/Comfy-Org/desktop/commit/e3704d0005b92ff68a0f954dcc753c00bdfdc0da) Add terminal output of manager package update ### 📊 Changes **5 files changed** (+51 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/infrastructure/interfaces.ts` (+2 -1) 📝 `src/install/installationManager.ts` (+18 -0) 📝 `src/main-process/comfyInstallation.ts` (+8 -2) 📝 `src/preload.ts` (+1 -0) 📝 `src/virtualEnvironment.ts` (+22 -6) </details> ### 📄 Description - Requires https://github.com/Comfy-Org/ComfyUI_frontend/pull/2454 - Adds ability to parse uv output when detecting installed python packages - Adds check for the manager package update (`toml`, `uv`) - Adds validation entry `managerPythonPackages` - reports warning - Notifies user by loading new desktop-update route - Resolves #834 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-841-Add-manager-package-checks-1926d73d365081b9bf18f3010a65e66b) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:48 +00:00

[PR #1143] [MERGED] 0.4.45 #1367

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1143

No description provided.

Rows
Columns