[PR #850] [MERGED] Fix window position / size does not fit in primary display #1149

New issue

Closed

opened 2026-10-31 22:19:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:19:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/850
Author: @webfiltered
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @webfiltered

Base: main ← Head: window-restore-state

📝 Commits (7)

433bcb8 Remove redundant code
84cda94 Ensure window is repositioned on screen
3508650 Ensure window fits in display area
c9e0a9b nit
9df9ca6 Add clamp function
5b301af [Refactor] Use clamp
798272d nit

📊 Changes

2 files changed (+31 additions, -6 deletions)

View changed files

📝 src/main-process/appWindow.ts (+20 -6)
📝 src/utils.ts (+11 -0)

📄 Description

Follow-up on #848
Ensures newly created window is contained within primary display
Clamps size
Clamps position
Moves to closest corner / edge if out of bounds
Resolves https://github.com/Comfy-Org/desktop/issues/849#issuecomment-2641362020

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/850 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `window-restore-state` --- ### 📝 Commits (7) - [`433bcb8`](https://github.com/Comfy-Org/desktop/commit/433bcb89b511bd55ddf4482ac74d359ef713935a) Remove redundant code - [`84cda94`](https://github.com/Comfy-Org/desktop/commit/84cda9495d77902bca4800d5032865cb52f7590e) Ensure window is repositioned on screen - [`3508650`](https://github.com/Comfy-Org/desktop/commit/35086503430ef1e77a4057312b4b63b831f65457) Ensure window fits in display area - [`c9e0a9b`](https://github.com/Comfy-Org/desktop/commit/c9e0a9bb66ee08f1584c6f38311b3b82e720fea0) nit - [`9df9ca6`](https://github.com/Comfy-Org/desktop/commit/9df9ca6a8b59b5ad6af93e228e59a9451046e699) Add clamp function - [`5b301af`](https://github.com/Comfy-Org/desktop/commit/5b301af5f447583e923ac4f0e25fbabbaf995286) [Refactor] Use clamp - [`798272d`](https://github.com/Comfy-Org/desktop/commit/798272d34d10f3f3a279d58983deb89c5b19eee5) nit ### 📊 Changes **2 files changed** (+31 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+20 -6) 📝 `src/utils.ts` (+11 -0) </details> ### 📄 Description - Follow-up on #848 - Ensures newly created window is contained within primary display - Clamps size - Clamps position - Moves to closest corner / edge if out of bounds - Resolves https://github.com/Comfy-Org/desktop/issues/849#issuecomment-2641362020 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-850-Fix-window-position-size-does-not-fit-in-primary-display-1936d73d3650816bbb71ddcd0b39210f) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:19:56 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:50 +00:00

[PR #1149] [MERGED] [chore] Update workflow templates to 0.1.11 #1370

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1149

No description provided.

Rows
Columns