[PR #866] [MERGED] Fix virtual env won't load on linux #1165

New issue

Closed

opened 2026-10-31 22:20:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/866
Author: @christian-byrne
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @webfiltered

Base: main ← Head: fix-linux-install

📝 Commits (5)

92117c3 reset env in uv shell on linux
a0d2b08 update test
4b185d6 revert env reset
f26edb9 update test expectation
a39e95d target linux explicitly, preserve original fallback

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 src/shell/util.ts (+8 -1)
📝 tests/unit/shell/util.test.ts (+2 -2)

📄 Description

Various environment variables can interfere with the install process, including modifications to PATH made by python version managers (inserting shims). Bypassing shell profiles alone is not enough because environment variables will already be set in the parent process and inherited.

https://github.com/user-attachments/assets/ec810a1f-05f8-49d1-bd83-1f7433df4af4

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/866 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-linux-install` --- ### 📝 Commits (5) - [`92117c3`](https://github.com/Comfy-Org/desktop/commit/92117c3aa46368715c3e33af0578d56a6b132d50) reset env in uv shell on linux - [`a0d2b08`](https://github.com/Comfy-Org/desktop/commit/a0d2b08a6c07cd02ba3402bd9f0d985f2c025ede) update test - [`4b185d6`](https://github.com/Comfy-Org/desktop/commit/4b185d63a890a1d282a73d07e5c688dadf6bf84f) revert env reset - [`f26edb9`](https://github.com/Comfy-Org/desktop/commit/f26edb9c6e2cebab6d26d2c58e54c4511dedb147) update test expectation - [`a39e95d`](https://github.com/Comfy-Org/desktop/commit/a39e95d6fa9e453add4fffce4e7b9ec84590e5e3) target linux explicitly, preserve original fallback ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/shell/util.ts` (+8 -1) 📝 `tests/unit/shell/util.test.ts` (+2 -2) </details> ### 📄 Description Various environment variables can interfere with the install process, including modifications to PATH made by python version managers (inserting shims). Bypassing shell profiles alone is not enough because environment variables will already be set in the parent process and inherited. https://github.com/user-attachments/assets/ec810a1f-05f8-49d1-bd83-1f7433df4af4 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-866-Fix-virtual-env-won-t-load-on-linux-1946d73d36508188839cd61b85e97e17) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:03 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1165

No description provided.

Rows
Columns