[PR #867] [MERGED] Debounce and batch window settings writes #1167

New issue

Closed

opened 2026-10-31 22:20:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/867
Author: @christian-byrne
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @webfiltered

Base: main ← Head: cb-debounce-window-setting

📝 Commits (5)

e94559a add debounce to window settings
9e3521b fix maximized reset and inline debounce call
d9a570a update comment
cc686a3 Update src/main-process/appWindow.ts
4d11f0b Update src/main-process/appWindow.ts

📊 Changes

3 files changed (+36 additions, -15 deletions)

View changed files

📝 package.json (+2 -0)
📝 src/main-process/appWindow.ts (+24 -14)
📝 yarn.lock (+10 -1)

📄 Description

Batches and adds debounce to window position saving to reduce disk writes (currently writes to window.json many times per second). Use both leading and trailing edge debounce to ensure capture of both immediate changes (like un-maximizing before close) and final positions after movement stops.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/867 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `cb-debounce-window-setting` --- ### 📝 Commits (5) - [`e94559a`](https://github.com/Comfy-Org/desktop/commit/e94559ab5f179f60f7df233c128fe640af07f2e7) add debounce to window settings - [`9e3521b`](https://github.com/Comfy-Org/desktop/commit/9e3521bdd7000d9fcd37edaf359898d5ac18bc6c) fix maximized reset and inline debounce call - [`d9a570a`](https://github.com/Comfy-Org/desktop/commit/d9a570a4a1204e2921a2343adb8166976af86207) update comment - [`cc686a3`](https://github.com/Comfy-Org/desktop/commit/cc686a3e6d9a45ea4eea867801444a68ff25a2d8) Update src/main-process/appWindow.ts - [`4d11f0b`](https://github.com/Comfy-Org/desktop/commit/4d11f0b77b9c9949c6bb5dcb5ea7507b583a196e) Update src/main-process/appWindow.ts ### 📊 Changes **3 files changed** (+36 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -0) 📝 `src/main-process/appWindow.ts` (+24 -14) 📝 `yarn.lock` (+10 -1) </details> ### 📄 Description Batches and adds debounce to window position saving to reduce disk writes (currently writes to `window.json` many times per second). Use both leading and trailing edge debounce to ensure capture of both immediate changes (like un-maximizing before close) and final positions after movement stops. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-867-Debounce-and-batch-window-settings-writes-1946d73d365081f88621f4270713b827) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:04 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1167

No description provided.

Rows
Columns