[PR #871] [MERGED] Ensure users do not use the CPU mirror for non-CPU installs #1169

New issue

Closed

opened 2026-10-31 22:20:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/871
Author: @webfiltered
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @webfiltered

Base: main ← Head: ensure-valid-mirrors

📝 Commits (4)

c208a4a Fix cannot start app - uv cmd invalid URL
8b48edf nit
2857d0f Ensure users do not use the CPU mirror for non-CPU installs
24a42cf nit

📊 Changes

2 files changed (+17 additions, -6 deletions)

View changed files

📝 src/constants.ts (+1 -0)
📝 src/virtualEnvironment.ts (+16 -6)

📄 Description

Resolves cannot start app after uv command fails - empty index URL
Silently corrects use of default python mirror to default mirror for selected device
Resolves issue where user is unable to start the app due to an invalid mirror configuration

The mirror correction is a workaround that should be expanded into a proper feature, or removed.

#870

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/871 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `ensure-valid-mirrors` --- ### 📝 Commits (4) - [`c208a4a`](https://github.com/Comfy-Org/desktop/commit/c208a4a76dee8e318f8d5d6b19ab05e90682c730) Fix cannot start app - uv cmd invalid URL - [`8b48edf`](https://github.com/Comfy-Org/desktop/commit/8b48edf5d2ff3647d71fa32a435db64b731919ec) nit - [`2857d0f`](https://github.com/Comfy-Org/desktop/commit/2857d0f50adbff647b2e745d028917c032a38f19) Ensure users do not use the CPU mirror for non-CPU installs - [`24a42cf`](https://github.com/Comfy-Org/desktop/commit/24a42cf9ddaa91547461994a5eab9acd9ae3586c) nit ### 📊 Changes **2 files changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+1 -0) 📝 `src/virtualEnvironment.ts` (+16 -6) </details> ### 📄 Description - Resolves cannot start app after uv command fails - empty index URL - Silently corrects use of default python mirror to default mirror for selected device - Resolves issue where user is unable to start the app due to an invalid mirror configuration The mirror correction is a workaround that should be expanded into a proper feature, or removed. - #870 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-871-Ensure-users-do-not-use-the-CPU-mirror-for-non-CPU-installs-1946d73d365081679cc8c18fdc242080) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:56 +00:00

[PR #1169] [MERGED] v0.4.49 #1383

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1169

No description provided.

Rows
Columns