[PR #869] [CLOSED] Always log events locally (debug) #1170

New issue

Closed

opened 2026-10-31 22:20:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/869
Author: @webfiltered
Created: 2/8/2025
Status: ❌ Closed

Base: main ← Head: debug-log-events

📝 Commits (2)

aa85528 Always log events locally (debug level)
c8f794d Prefer structured logging over stringification

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/services/telemetry.ts (+2 -1)

📄 Description

Ensures events are logged locally for when debugging logs are enabled
Removes manual stringification in favour of structured logging

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/869 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `debug-log-events` --- ### 📝 Commits (2) - [`aa85528`](https://github.com/Comfy-Org/desktop/commit/aa85528d1440699b62937b0df26a52a4a034f4e5) Always log events locally (debug level) - [`c8f794d`](https://github.com/Comfy-Org/desktop/commit/c8f794d303b8ab21f08cba44df4cbfd05383853d) Prefer structured logging over stringification ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/services/telemetry.ts` (+2 -1) </details> ### 📄 Description - Ensures events are logged locally for when debugging logs are enabled - Removes manual stringification in favour of structured logging ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-869-Always-log-events-locally-debug-1946d73d36508118b3fad854f6c5d858) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:58 +00:00

[PR #1170] [MERGED] Add updated templates to compiled requirements. #1384

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1170

No description provided.

Rows
Columns