[PR #880] [MERGED] Capture and report caught exceptions #1175

New issue

Closed

opened 2026-10-31 22:20:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/880
Author: @christian-byrne
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @webfiltered

Base: main ← Head: cb-sentry-capture

📝 Commits (2)

92fd13d capture errors with sentry in track decorator
a2bd33d add capture for manually tracked error (not using decorator)

📊 Changes

8 files changed (+79 additions, -54 deletions)

View changed files

📝 src/services/sentry.ts (+52 -18)
📝 src/services/telemetry.ts (+6 -27)
📝 src/virtualEnvironment.ts (+3 -0)
📝 tests/unit/desktopApp.test.ts (+0 -1)
📝 tests/unit/install/installWizard.test.ts (+6 -4)
📝 tests/unit/install/installationManager.test.ts (+0 -4)
📝 tests/unit/main-process/comfyServer.test.ts (+6 -0)
📝 tests/unit/services/telemetry.test.ts (+6 -0)

📄 Description

Reverts https://github.com/Comfy-Org/desktop/pull/739 in favor of manually capturing exceptions in track and trackEvent, which is preferable because it doesn't require exceptions to go uncaught/unresolved to be logged. Additionally, adds fields for mirror settings and last 64 lines of log file.

Example event: Sentry | Mixpanel

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/880 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `cb-sentry-capture` --- ### 📝 Commits (2) - [`92fd13d`](https://github.com/Comfy-Org/desktop/commit/92fd13d6974873902124e830b0ea6f002b43d502) capture errors with sentry in track decorator - [`a2bd33d`](https://github.com/Comfy-Org/desktop/commit/a2bd33dd942649eb86ae8387f6220c8ef06ac2a0) add capture for manually tracked error (not using decorator) ### 📊 Changes **8 files changed** (+79 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/services/sentry.ts` (+52 -18) 📝 `src/services/telemetry.ts` (+6 -27) 📝 `src/virtualEnvironment.ts` (+3 -0) 📝 `tests/unit/desktopApp.test.ts` (+0 -1) 📝 `tests/unit/install/installWizard.test.ts` (+6 -4) 📝 `tests/unit/install/installationManager.test.ts` (+0 -4) 📝 `tests/unit/main-process/comfyServer.test.ts` (+6 -0) 📝 `tests/unit/services/telemetry.test.ts` (+6 -0) </details> ### 📄 Description Reverts https://github.com/Comfy-Org/desktop/pull/739 in favor of manually capturing exceptions in `track` and `trackEvent`, which is preferable because it doesn't require exceptions to go uncaught/unresolved to be logged. Additionally, adds fields for mirror settings and last 64 lines of log file. Example event: [Sentry](https://comfy-org.sentry.io/issues/6283123346/events/3065c15d414c4176acf548f3afba96c6/?project=4508007940685824) | [Mixpanel](https://mixpanel.com/project/3484456/view/3986560/app/profile#distinct_id=f1f2c45a-1f07-4edb-9583-c2a9b070521e) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-880-Capture-and-report-caught-exceptions-1956d73d365081a6a239f114281d602e) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:08 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1175

No description provided.

Rows
Columns