[PR #883] [MERGED] [Logging] Use structured logging for all errors & objects #1177

New issue

Closed

opened 2026-10-31 22:20:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/883
Author: @webfiltered
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @webfiltered

Base: main ← Head: more-structure

📝 Commits (7)

dfa727f Log precise command sent to uv terminal
4dc8de2 Use structured logging
4e6a819 Prefer structured logging
d25edd3 Replace double-log calls with structured logging
51d9cd9 Prefer structured logging
5398e4a nit
2cc92ad Update test expectations

📊 Changes

8 files changed (+24 additions, -22 deletions)

View changed files

📝 src/config/comfyConfigManager.ts (+1 -1)
📝 src/main-process/appWindow.ts (+2 -3)
📝 src/main-process/comfyDesktopApp.ts (+1 -2)
📝 src/main-process/comfyServer.ts (+1 -1)
📝 src/models/DownloadManager.ts (+4 -4)
📝 src/services/cmCli.ts (+2 -2)
📝 src/virtualEnvironment.ts (+9 -8)
📝 tests/unit/config/comfyConfigManager.test.ts (+4 -1)

📄 Description

Applies structured logging syntax to every log call site
Removes redundant sequential logging calls
Changes uv command logging to log the precise command sent, rather than stripping formatting

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/883 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `more-structure` --- ### 📝 Commits (7) - [`dfa727f`](https://github.com/Comfy-Org/desktop/commit/dfa727f0b1a18d27963f9851795ff355b49cf8c6) Log precise command sent to uv terminal - [`4dc8de2`](https://github.com/Comfy-Org/desktop/commit/4dc8de24fe9066e7eb3c66f55f3ed58bd1a8f0f0) Use structured logging - [`4e6a819`](https://github.com/Comfy-Org/desktop/commit/4e6a819ada006873bc7682124f9f5d147c1cec0d) Prefer structured logging - [`d25edd3`](https://github.com/Comfy-Org/desktop/commit/d25edd383532e5b03ebd6c75688dd73517f467eb) Replace double-log calls with structured logging - [`51d9cd9`](https://github.com/Comfy-Org/desktop/commit/51d9cd9da8bae6300655164a89bbcff6524e5df2) Prefer structured logging - [`5398e4a`](https://github.com/Comfy-Org/desktop/commit/5398e4a6877f82a7f1ea832061ab4dfed7a984a1) nit - [`2cc92ad`](https://github.com/Comfy-Org/desktop/commit/2cc92adf1d7f3dff2979614d1e2bca9bc7982d06) Update test expectations ### 📊 Changes **8 files changed** (+24 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyConfigManager.ts` (+1 -1) 📝 `src/main-process/appWindow.ts` (+2 -3) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -2) 📝 `src/main-process/comfyServer.ts` (+1 -1) 📝 `src/models/DownloadManager.ts` (+4 -4) 📝 `src/services/cmCli.ts` (+2 -2) 📝 `src/virtualEnvironment.ts` (+9 -8) 📝 `tests/unit/config/comfyConfigManager.test.ts` (+4 -1) </details> ### 📄 Description - Applies structured logging syntax to every log call site - Removes redundant sequential logging calls - Changes uv command logging to log the precise command sent, rather than stripping formatting ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-883-Logging-Use-structured-logging-for-all-errors-objects-1966d73d365081c2897ce77186099cb0) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:08 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:58 +00:00

[PR #1177] [MERGED] Bump comfyUI version to support additional API nodes. #1387

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1177

No description provided.

Rows
Columns